From dev-return-8650-apmail-stdcxx-dev-archive=stdcxx.apache.org@stdcxx.apache.org Fri Sep 7 02:37:15 2012 Return-Path: X-Original-To: apmail-stdcxx-dev-archive@www.apache.org Delivered-To: apmail-stdcxx-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9DF87D815 for ; Fri, 7 Sep 2012 02:37:15 +0000 (UTC) Received: (qmail 65520 invoked by uid 500); 7 Sep 2012 02:37:15 -0000 Delivered-To: apmail-stdcxx-dev-archive@stdcxx.apache.org Received: (qmail 65439 invoked by uid 500); 7 Sep 2012 02:37:15 -0000 Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stdcxx.apache.org Delivered-To: mailing list dev@stdcxx.apache.org Received: (qmail 65431 invoked by uid 99); 7 Sep 2012 02:37:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Sep 2012 02:37:15 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of msebor@gmail.com designates 209.85.214.182 as permitted sender) Received: from [209.85.214.182] (HELO mail-ob0-f182.google.com) (209.85.214.182) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Sep 2012 02:37:09 +0000 Received: by obbun3 with SMTP id un3so3806903obb.41 for ; Thu, 06 Sep 2012 19:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Rg/5L8V2XcpYPP+oj7HYxBOGeZSzte9Om8z/cU3tpkU=; b=NU/0PJ1u1kgyTQHvq0xivXHP0s2J8BtTfTEkyQw0G7tB5UP/DBgcIzXC7fDwDyVWs3 t8lQP74yI7wPk7p/CgV03Zz7MgcrNu0Ai09fkPnJEwaWOwIe9xwnF/j7vdHAumYTrr72 QwCfaPEwwwAmpwygcDYECXZDdH767901igDDTvWrt82l+3LzzGVyYPuxGk6Sdp3iLoSg rpYPeB0B++37V1tBbWfsYPKARB22HRCICDeuX3YvHVedZTL1LP6zT3XCdGSMh0PJFfkW bZd6+XslTz2r7q2wVOr2HF0IU7SGWseVrsS4BJddeKUNVgHekKsrmS7/IJlM7xYdb0y5 dsNg== Received: by 10.182.202.1 with SMTP id ke1mr4293047obc.51.1346985409154; Thu, 06 Sep 2012 19:36:49 -0700 (PDT) Received: from [10.99.105.173] (72-163-0-129.cisco.com. [72.163.0.129]) by mx.google.com with ESMTPS id ec1sm3671446obc.2.2012.09.06.19.36.47 (version=SSLv3 cipher=OTHER); Thu, 06 Sep 2012 19:36:48 -0700 (PDT) Message-ID: <50495DBE.4010208@gmail.com> Date: Thu, 06 Sep 2012 20:36:46 -0600 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: dev@stdcxx.apache.org CC: Wojciech Meyer Subject: Re: A question (or two) of procedure, etc. References: <5048E63F.8090603@hates.ms> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Anyone is welcome to express their opinion here, especially if you are or have in the past contributed to the project. The weight of the opinion is (or should be) commensurate to the value of the contributions. I think the ASF calls this Meritocracy. I made the stdcxx process increasingly more formal as I learned from my own past mistakes that a loose process makes it harder to track changes and find the root cause of the problems they sometimes introduce. In practical terms, I've made an effort to have an issue, with a test case if possible, for every change made to the code, and commit a regression test into the test suite for every bug fix. FWIW, in my day to day job, this is a requirement. Cisco doesn't make a change to its code without an issue. My team does the same with GCC changes. We find that projects that don't follow this practice as closely (e.g., GNU Binutils), tend to be more difficult for us to work with than those that do. That being said, when it comes to the stdcxx configuration machinery, or to the test suite, I think it's fine to be somewhat less formal. We don't need test cases for problems in configuration tests, or necessarily even test cases reproducing failures in library tests (although small tests can often be more useful than the large tests we have in the test suite). We also don't need tests for makefile bugs. Outside of that, when it comes to changing the library, I do recommend making an effort to create test cases and open issues for all changes. Martin On 09/06/2012 12:37 PM, Wojciech Meyer wrote: > Liviu Nicoara writes: > >> What is the latest policy in what regards trivial fixes, e.g., the >> volatile qualifier for the max var in LIMITS.cpp we discussed earlier, >> etc.? It seems excessive to create a bug report for such issues. > > My advice based on some observations with other projects, is that in > these cases we go just go on and apply fix. Non invasive code quality > improvements over the codebase should be promoted not hindered. More > risky patches, should be discussed on the list, the ones that needs > either serious changes, attention, re-factoring, feature or fixes that > may break something should be logged in Jira. > > So I vote for keeping the changes as lightweight as possible, and avoid > extra bureaucracy if it makes sense. This assumption is based that > developers here trust their selves, and run the tests often. I'm not > subscribed to the commit list here, but if I do - I usually follow > people's changes and assume that developers do read commit lists. > > So the general consensus from my experience with other project was: not > sure - ask. > > That's my experience, also I don't have full rights to express my > opinion right now about stdcxx. > >> Also, IIUC from reading previous discussions, forward and backward >> binary compatible changes go in 4.2.x, followed by merges to 4.3.x and >> trunk. Am I getting this right? > > Every project has certain branch strategy, I'm not sure about this so > maybe Martin can advice. I prefer to develop on trunk and cherry pick > to the other branches avoiding bulk merges (and that's in both > directions). > >> >> Also, besides the Linux, FreeBSD, Windows, Solaris builds hosted on Apache (Jenkins) is anybody building on HP-UX, AIX, etc.? >> >> Thanks. >> >> Liviu >> > > -- > Wojciech Meyer > http://danmey.org