incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Travis Vitek <Travis.Vi...@roguewave.com>
Subject RE: [jira] [Updated] (STDCXX-1058) std::basic_ios<>::copyfmt() with registered callback (via std::ios_base::register_callback()) run-time SIGABRT
Date Wed, 16 May 2012 17:55:45 GMT
I approve the change, but with one caveat. The branching policy [1] indicates that you should
commit your changes directly to the 4.2.x branch. They should be merged from 4.2.x to 4.3.x,
and then from 4.3.x to trunk.

It has been a long time since I've worked actively on the stdcxx project, but it seems that
if seeking feedback on a patch before committing you would send something to the list. It
seems that trivial changes were committed to the appropriate branch without prior review.
Unfortunately, the committers page [2] indicates that my memory is wrong.

Travis

[1] http://wiki.apache.org/stdcxx/Branching
[2] http://stdcxx.apache.org/index.html#committers


Index: 4.2.x/src/iostore.cpp
===================================================================
--- 4.2.x/src/iostore.cpp	(revision 1055501)
+++ 4.2.x/src/iostore.cpp	(working copy)
@@ -335,8 +335,14 @@
             // delete existing arrays, if any; _C_usr will only be deleted
             // if `rhs' contains no user data (see below)
             operator delete (_C_usr->_C_iarray);
+            _C_usr->_C_iarray = 0;
+            _C_usr->_C_isize = 0;
             operator delete (_C_usr->_C_parray);
+            _C_usr->_C_parray = 0;
+            _C_usr->_C_psize = 0;
             operator delete (_C_usr->_C_cbarray);
+            _C_usr->_C_cbarray = 0;
+            _C_usr->_C_cbsize = 0;
         }
         else if (ia || pa || cba || ptie) {
             // allocation may throw

Mime
View raw message