Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@stdcxx.apache.org
Received-SPF: pass (athena.apache.org: domain of stefan.teleman@gmail.com
 designates 209.85.212.202 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=W2wm11j+g82VwjsV57Ru0Z1o5tPF5LftLbh//BS8GmXIRe9uGXYoDQWPNwLCjbdSYK
         ApSZREXUMshVmMYLWy9dfPOyZ73VNOPdvJPyD2NqoifUqcEVGWt2F95QDEZv71Hois4K
         Z7TIPUJYNYqxcXIZ9RUnAvCN946Ffh47tUB74=
MIME-Version: 1.0
In-Reply-To: <4A85C808.7060809@gmail.com>
References: <4A85B875.6060609@gmail.com>
	 <1ccb59a20908141227p1754544fl5925148b26805ac9@mail.gmail.com>
	 <4A85C808.7060809@gmail.com>
Date: Mon, 17 Aug 2009 10:27:37 -0400
Message-ID: <1ccb59a20908170727p7630e92vd9353f3684fca32b@mail.gmail.com>
Subject: Re: Soalris 10 10/2008 SPARC changes (was: Re: 4.2.2 release)
From: Stefan Teleman <stefan.teleman@gmail.com>
To: dev@stdcxx.apache.org
Cc: Stefan Teleman <stefan.teleman@sun.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On Fri, Aug 14, 2009 at 16:24, Martin Sebor<msebor@gmail.com> wrote:
> Thanks for the heads up and the patches! I'll review apply them
> if possible/necessary before the release.
>
> I took a quick glance at a few of the diff files and I wonder if
> you could help me better understand some of the changes in case
> they could be applied unconditionally.
>
> For instance, in ctype.cpp.38.diff, it seems as though the second
> hunk would be a good change to make regardless (when long long is
> available). Ditto for the third hunk in locale_body.37.diff (minus
> the pragmas, of course), and similarly in locale_classic.40.diff
> and messages.cpp.41.diff.
>
> The approach I'm thinking of using is the one you applied in
> use_facet.h, i.e., defining, say, _RWSTD_ALIGN_MAX_T to unsigned
> long long, and using it in all the aligned buffers, along with
> unsigned char for the data.
>
> Other than these, can you also help me understand the changes in
> messages.cpp.41.diff (starting with the third hunk on line 92)?

That's my bad mistake -- i created a diff for src/messages.cpp from an
older version of messages.cpp (hacked while i was trying to figure out
why it was misbehaving so badly on 32-bit SPARCv8).

I updated the tarball and the messages.cpp.41.diff itself with a valid
patch now. Sorry for the noise.

About

int ret = catclose (pcat_data->catd);

// ...

cat_closed = ret == 0;

My understanding of 22.2.7.1.2, p5 (catalog must be valid) is that  --
if catclose(3C) fails, it means the catalog was not valid -- therefore
the C++ library must throw. So, cat_closed is now true if and only if
catclose(3C) succeeded.  Or is this too restrictive ?

About the other patches -- and whether or not they should be applied
for other platforms besides Solaris/SPARC: i tried not to disturb any
other ISA's/compiler combinations. If you'd like i can re-write the
patches for 4.2.2 using the more generic approach you described.

--Stefan

-- 
Stefan Teleman
stefan.teleman@gmail.com