From dev-return-8334-apmail-stdcxx-dev-archive=stdcxx.apache.org@stdcxx.apache.org Sat Nov 15 18:33:57 2008 Return-Path: Delivered-To: apmail-stdcxx-dev-archive@www.apache.org Received: (qmail 78780 invoked from network); 15 Nov 2008 18:33:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Nov 2008 18:33:57 -0000 Received: (qmail 7560 invoked by uid 500); 15 Nov 2008 18:34:05 -0000 Delivered-To: apmail-stdcxx-dev-archive@stdcxx.apache.org Received: (qmail 7537 invoked by uid 500); 15 Nov 2008 18:34:05 -0000 Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stdcxx.apache.org Delivered-To: mailing list dev@stdcxx.apache.org Received: (qmail 7526 invoked by uid 99); 15 Nov 2008 18:34:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Nov 2008 10:34:05 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of msebor@gmail.com designates 209.85.146.180 as permitted sender) Received: from [209.85.146.180] (HELO wa-out-1112.google.com) (209.85.146.180) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Nov 2008 18:32:43 +0000 Received: by wa-out-1112.google.com with SMTP id k40so1050079wah.31 for ; Sat, 15 Nov 2008 10:33:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=7H9JiNARpL+Xy6/goSuIjH/9gyDKdaBUG8pFKsMj/dY=; b=p8SJX1igds7gZKG8WBStufSu7MjTnkm7Ch89hluFMJ6A+B70OGhEjHlDK13GY78QRS 1i9FRDbrwXG1uNl1RMpsJcUWC82jF5TCvCIolsaxPxcdZGoch7BUa4EDERJMqBAu+AjV +XnowfUlHVj+rHDuPNsjc3dLqVsLvrA99QnGQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=VdFfuVdFJ8+RSNW25rpfd3ZykiJbWSIKfsbXDAhtcgUxFvVJKVtNVW4BksK8/Kv4LD QH7GOv33XbJUYEnWmGL/OsP1TJggEFknUK7YMB+8+aw2UINNwp2uwhxaFvzDK7Qa4cBD wx62neu/OT0hJl0FgE3RPFehCjNlxyyhfZazg= Received: by 10.115.16.14 with SMTP id t14mr1403092wai.185.1226774007294; Sat, 15 Nov 2008 10:33:27 -0800 (PST) Received: from bugsy.net (c-71-229-200-170.hsd1.co.comcast.net [71.229.200.170]) by mx.google.com with ESMTPS id m26sm4052721pof.17.2008.11.15.10.33.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 15 Nov 2008 10:33:26 -0800 (PST) Message-ID: <491F15F5.1030906@gmail.com> Date: Sat, 15 Nov 2008 11:33:25 -0700 From: Martin Sebor User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: dev@stdcxx.apache.org Subject: Re: svn commit: r713762 - /stdcxx/branches/4.2.x/include/rw/_config.h References: <20081113175751.4155A238893B@eris.apache.org> In-Reply-To: <20081113175751.4155A238893B@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org I wonder if it would be worthwhile to give users the ability to decide whether to enable TLS in case they don't need LoadLibrary() or not. What do you think? Martin faridz@apache.org wrote: > Author: faridz > Date: Thu Nov 13 09:57:50 2008 > New Revision: 713762 > > URL: http://svn.apache.org/viewvc?rev=713762&view=rev > Log: > 2008-11-13 Farid Zaripov > > STDCXX-1023 > * include/rw/_config.h [_WIN32 && _RWSTD_LIB_SRC]: Disable > using of implicit TLS variables in stdcxx library on Windows. > > Modified: > stdcxx/branches/4.2.x/include/rw/_config.h > > Modified: stdcxx/branches/4.2.x/include/rw/_config.h > URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/include/rw/_config.h?rev=713762&r1=713761&r2=713762&view=diff > ============================================================================== > --- stdcxx/branches/4.2.x/include/rw/_config.h (original) > +++ stdcxx/branches/4.2.x/include/rw/_config.h Thu Nov 13 09:57:50 2008 > @@ -278,6 +278,18 @@ > #ifdef _WIN32 > # define _RWSTD_NO_STATIC_MUTEX_INIT > # define _RWSTD_PATH_SEP '\\' > +# ifdef _RWSTD_LIB_SRC > + // Don't use implicit TLS in our library on Windows because of the TLS > + // might not be initialized when our library DLL or the DLL, that > + // linked statically against our library, is loaded explicitly using > + // LoadLibrary() function. (STDCXX-1023) > +# ifndef _RWSTD_NO_TLS > +# define _RWSTD_NO_TLS > +# endif > +# ifdef _RWSTD_THREAD > +# undef _RWSTD_THREAD > +# endif > +# endif // _RWSTD_LIB_SRC > #endif // _WIN32 > > #ifndef _RWSTD_PATH_SEP > > >