From dev-return-8112-apmail-stdcxx-dev-archive=stdcxx.apache.org@stdcxx.apache.org Thu Jul 03 02:56:32 2008 Return-Path: Delivered-To: apmail-stdcxx-dev-archive@www.apache.org Received: (qmail 8623 invoked from network); 3 Jul 2008 02:56:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jul 2008 02:56:32 -0000 Received: (qmail 11601 invoked by uid 500); 3 Jul 2008 02:56:33 -0000 Delivered-To: apmail-stdcxx-dev-archive@stdcxx.apache.org Received: (qmail 11586 invoked by uid 500); 3 Jul 2008 02:56:33 -0000 Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stdcxx.apache.org Delivered-To: mailing list dev@stdcxx.apache.org Received: (qmail 11575 invoked by uid 99); 3 Jul 2008 02:56:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jul 2008 19:56:33 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of msebor@gmail.com designates 209.85.198.232 as permitted sender) Received: from [209.85.198.232] (HELO rv-out-0506.google.com) (209.85.198.232) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jul 2008 02:55:41 +0000 Received: by rv-out-0506.google.com with SMTP id g37so659189rvb.23 for ; Wed, 02 Jul 2008 19:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :organization:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding:sender; bh=pVj0GrIAoRhV8oeZlXHMb0iGD2RJYEzdCOzoCEvdsFg=; b=bC0NuofAdlLXagPqONvvp++Cl/TYd+tlnits5Tkd9/UcHb4B7/BZCwAdSDT0XZ6hY3 HAi10wflUoR49AKcYaO+MDVqfVYVS/LCoyxY3t4+qLDRAiq6rUCrY0OCNUSY66JXO7yA 8XWzJFa8JfBkZ6zApvOJ6P2L6X3ouuTijRtAg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:organization:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding:sender; b=W4q+x2vYv7Ywd99cQmh2WT8rYagrBd88XlF1m7x5dLQ65DEe66nv8VDI6nl56simfv q/Is+w5dzj3TF5yNZYXZtmnS8aDtP3kQc1vuc6jTsMuSEHw9N6FuNXOzoTWg8cX5FaEX F0bTW17BE85Oqvv1hMkNcpsmyLZyuL5n5LWDk= Received: by 10.141.63.20 with SMTP id q20mr4769544rvk.258.1215053762209; Wed, 02 Jul 2008 19:56:02 -0700 (PDT) Received: from localhost.localdomain ( [71.229.200.170]) by mx.google.com with ESMTPS id f42sm12348029rvb.5.2008.07.02.19.56.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 02 Jul 2008 19:56:01 -0700 (PDT) Message-ID: <486C3FC0.5050007@roguewave.com> Date: Wed, 02 Jul 2008 20:56:00 -0600 From: Martin Sebor Organization: Rogue Wave Software, Inc. User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: dev@stdcxx.apache.org Subject: Re: svn commit: r672395 - in /stdcxx/branches/4.3.x/include: functional rw/_ref_wrap.h References: <20080627211030.CA5CB2388A06@eris.apache.org> <4866A442.5080700@roguewave.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: Martin Sebor X-Virus-Checked: Checked by ClamAV on apache.org Eric Lemings wrote: > > >> -----Original Message----- >> From: Martin Sebor [mailto:msebor@gmail.com] On Behalf Of Martin Sebor >> Sent: Saturday, June 28, 2008 2:51 PM >> To: dev@stdcxx.apache.org >> Subject: Re: svn commit: r672395 - in >> /stdcxx/branches/4.3.x/include: functional rw/_ref_wrap.h >> > ... >> 5. The definitions of even trivial non-empty functions should >> never appear on the same line as the function signature. I.e., >> the above should be: >> >> type& get() const { >> _RWSTD_ASSERT (0 != _C_ptr); >> return *_C_ptr; >> } > > I assume empty function definitions are exempted from this convention? Yes. As you noted, there are functions that don't follow this convention. Most of them are in ancient code that hasn't been touched in a decade. You can even find code that uses 2 space indents, or that drops the opening curly brace (e.g., after an if or else). , esp. vector, is an example. At some point in the future it would be nice to reformat this code to follow the prevailing convention. Martin