incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r669999 - /stdcxx/branches/4.3.x/include/rw/_meta_other.h
Date Mon, 23 Jun 2008 17:11:29 GMT
vitek@apache.org wrote:
> Author: vitek
> Date: Fri Jun 20 10:27:42 2008
> New Revision: 669999
> 
> URL: http://svn.apache.org/viewvc?rev=669999&view=rev
> Log:
> 2008-06-20  Travis Vitek  <vitek@roguewave.com>
> 
> 	STDCXX-926
> 	* include/rw/_meta_other.h: Remove unnecessary whitespace,
> 	simplify workaround for msvc.
> 
> Modified:
>     stdcxx/branches/4.3.x/include/rw/_meta_other.h
> 
> Modified: stdcxx/branches/4.3.x/include/rw/_meta_other.h
> URL: http://svn.apache.org/viewvc/stdcxx/branches/4.3.x/include/rw/_meta_other.h?rev=669999&r1=669998&r2=669999&view=diff
> ==============================================================================
> --- stdcxx/branches/4.3.x/include/rw/_meta_other.h (original)
> +++ stdcxx/branches/4.3.x/include/rw/_meta_other.h Fri Jun 20 10:27:42 2008
> @@ -266,31 +266,31 @@
>  struct __rw_biggest
>  {
>      typedef typename
> -    __rw_conditional<(  sizeof _Type1 < sizeof _Type2),
> +    __rw_conditional<(sizeof _Type1 < sizeof _Type2),

The type argument to sizeof needs to be enclosed in parens.
If the code compiles as is we should report it as a bug to
the compiler vendor.

Martin


Mime
View raw message