Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@stdcxx.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [jira] Commented: (STDCXX-866) add 22.locale.ctype.widen.cpp
Date: Tue, 29 Apr 2008 15:00:31 -0600
Message-ID: 
 <CFFDD219128FD94FB4F92B99F52D0A49010A3756@exchmail01.Blue.Roguewave.Com>
Thread-Topic: [jira] Commented: (STDCXX-866) add 22.locale.ctype.widen.cpp
Thread-Index: AcipcEBYBDxSZVIMSiCATRQg7meKCgAywIBw
References: <1750103546.1208457804295.JavaMail.jira@brutus>
 <480D54F0.7070302@roguewave.com> <4816362C.1090405@roguewave.com>
From: "Eric Lemings" <Eric.Lemings@roguewave.com>
To: <dev@stdcxx.apache.org>

=20
Now that I've looked closer at both tests, I think you're right: the
22.locale.ctype.narrow tests already exercises everything in the
22.locale.ctype.widen test.  Question is, do we want to just remove the
22.locale.ctype.widen test and leave the narrow test as it is or split
the narrow test into narrow and widen counterparts?

More generally, do we plan to integrate these new tests into subsequent
4.2.x releases or should they wait for 4.3?

Brad.

> -----Original Message-----
> From: Martin Sebor [mailto:sebor@roguewave.com]=20
> Sent: Monday, April 28, 2008 2:40 PM
> To: dev@stdcxx.apache.org
> Subject: Re: [jira] Commented: (STDCXX-866) add=20
> 22.locale.ctype.widen.cpp
>=20
> Brad, I've reopened the issue until we know that the new test
> really is needed (i.e., that it exercises functionality that's
> not also tested by 22.locale.ctype.narrow.cpp).
>=20
> Martin Sebor wrote:
> > Brad,
> >=20
> > You probably missed my question below: do we really need this test?
> >=20
> > Martin
> >=20
> > Martin Sebor (JIRA) wrote:
> >>     [=20
> >>=20
> https://issues.apache.org/jira/browse/STDCXX-866?page=3Dcom.atla
> ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focus
> edCommentId=3D12590141#action_12590141=20
> >> ]
> >> Martin Sebor commented on STDCXX-866:
> >> -------------------------------------
> >>
> >> I just noticed that=20
> >>=20
> [{{22.locale.ctype.narrow.cpp}}|http://svn.apache.org/repos/as
> f/stdcxx/trunk/tests/localization/22.locale.ctype.narrow.cpp]=20
> >> also exercises {{ctype::widen()}}. Does this new test do anything=20
> >> {{22.locale.ctype.narrow.cpp}} doesn't?
> >>
> >>> add 22.locale.ctype.widen.cpp
> >>> -----------------------------
> >>>
> >>>                 Key: STDCXX-866
> >>>                 URL:=20
> https://issues.apache.org/jira/browse/STDCXX-866
> >>>             Project: C++ Standard Library
> >>>          Issue Type: Sub-task
> >>>          Components: Tests
> >>>    Affects Versions: 4.1.2, 4.1.3, 4.1.4, 4.2.0
> >>>            Reporter: Martin Sebor
> >>>             Fix For: 4.2.1
> >>>
> >>>         Attachments: 22.locale.ctype.widen.cpp, 22_ctype_widen.cpp
> >>>
> >>>   Original Estimate: 2h
> >>>          Time Spent: 1h
> >>>  Remaining Estimate: 1h
> >>>
> >>> The test 22_ctype_widen.cpp needs to be migrated from the=20
> Rogue Wave=20
> >>> source code repository into Subversion under the name=20
> >>>=20
> [localization/22.locale.ctype.widen.cpp|http://svn.apache.org/
> repos/asf/stdcxx/trunk/tests/localization/22.locale.ctype.widen.cpp].=20
> >>>
> >>
> >=20
>=20
>=20