Return-Path: Delivered-To: apmail-stdcxx-dev-archive@www.apache.org Received: (qmail 5717 invoked from network); 15 Apr 2008 15:06:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Apr 2008 15:06:13 -0000 Received: (qmail 57381 invoked by uid 500); 15 Apr 2008 15:06:14 -0000 Delivered-To: apmail-stdcxx-dev-archive@stdcxx.apache.org Received: (qmail 57371 invoked by uid 500); 15 Apr 2008 15:06:14 -0000 Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stdcxx.apache.org Delivered-To: mailing list dev@stdcxx.apache.org Received: (qmail 57362 invoked by uid 99); 15 Apr 2008 15:06:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Apr 2008 08:06:14 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.roguewave.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Apr 2008 15:05:31 +0000 Received: from nebula.bco.roguewave.com ([10.70.3.27]) by moroha.roguewave.com (8.13.6/8.13.6) with ESMTP id m3FF5fMx012043 for ; Tue, 15 Apr 2008 15:05:42 GMT Message-ID: <4804C445.1080409@roguewave.com> Date: Tue, 15 Apr 2008 09:05:41 -0600 From: Martin Sebor Organization: Rogue Wave Software, Inc. User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: dev@stdcxx.apache.org Subject: Re: svn commit: r648131 - in /stdcxx/trunk/tests: localization/ strings/ References: <20080415065120.3D7851A983A@eris.apache.org> In-Reply-To: <20080415065120.3D7851A983A@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org faridz@apache.org wrote: > Author: faridz > Date: Mon Apr 14 23:51:12 2008 > New Revision: 648131 > > URL: http://svn.apache.org/viewvc?rev=648131&view=rev Thanks for cleaning this up! I wonder if it would make sense to enhance rw_printf() to check and assert the correct alignment of the arguments to help us detect at least some of these inconsistencies. Opinions? > Log: > 2008-04-15 Farid Zaripov > > * tests/localization/22.locale.codecvt.mt.cpp: Use %d format instead of %zu for printing > the number of iterations to avoid printing the incorrect value on LLP64 platforms). > * tests/localization/22.locale.cons.mt.cpp: Ditto. > * tests/localization/22.locale.ctype.mt.cpp: Ditto. > * tests/localization/22.locale.messages.mt.cpp: Ditto. > * tests/localization/22.locale.money.get.mt.cpp: Ditto. > * tests/localization/22.locale.money.put.mt.cpp: Ditto. > * tests/localization/22.locale.moneypunct.mt.cpp: Ditto. > * tests/localization/22.locale.num.get.mt.cpp: Ditto. > * tests/localization/22.locale.num.put.mt.cpp: Ditto. > * tests/localization/22.locale.numpunct.mt.cpp: Ditto. > * tests/localization/22.locale.statics.mt.cpp: Ditto. > * tests/localization/22.locale.time.get.mt.cpp: Ditto. > * tests/localization/22.locale.time.put.mt.cpp: Ditto. > * tests/strings/21.string.cons.mt.cpp: Ditto. > * tests/strings/21.string.push_back.mt.cpp: Ditto. > > Modified: > stdcxx/trunk/tests/localization/22.locale.codecvt.mt.cpp > stdcxx/trunk/tests/localization/22.locale.cons.mt.cpp > stdcxx/trunk/tests/localization/22.locale.ctype.mt.cpp > stdcxx/trunk/tests/localization/22.locale.messages.mt.cpp > stdcxx/trunk/tests/localization/22.locale.money.get.mt.cpp > stdcxx/trunk/tests/localization/22.locale.money.put.mt.cpp > stdcxx/trunk/tests/localization/22.locale.moneypunct.mt.cpp > stdcxx/trunk/tests/localization/22.locale.num.get.mt.cpp > stdcxx/trunk/tests/localization/22.locale.num.put.mt.cpp > stdcxx/trunk/tests/localization/22.locale.numpunct.mt.cpp > stdcxx/trunk/tests/localization/22.locale.statics.mt.cpp > stdcxx/trunk/tests/localization/22.locale.time.get.mt.cpp > stdcxx/trunk/tests/localization/22.locale.time.put.mt.cpp > stdcxx/trunk/tests/strings/21.string.cons.mt.cpp > stdcxx/trunk/tests/strings/21.string.push_back.mt.cpp > > Modified: stdcxx/trunk/tests/localization/22.locale.codecvt.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.codecvt.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.codecvt.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.codecvt.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -481,7 +481,7 @@ > > rw_info (0, 0, 0, > "testing std::codecvt with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > rw_opt_nthreads, 1 != rw_opt_nthreads, > rw_opt_nloops, 1 != rw_opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.cons.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.cons.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.cons.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.cons.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -176,7 +176,7 @@ > > rw_info (0, 0, 0, > "testing std::locale ctors with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > opt_nthreads, 1 != opt_nthreads, > opt_nloops, 1 != opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.ctype.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.ctype.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.ctype.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.ctype.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -248,7 +248,7 @@ > > rw_info (0, 0, 0, > "testing std::ctype with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > opt_nthreads, 1 != opt_nthreads, > opt_nloops, 1 != opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.messages.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.messages.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.messages.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.messages.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -246,7 +246,7 @@ > > rw_info (0, 0, 0, > "testing std::messages with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each", > + "%d iteration%{?}s%{;} each", > rw_opt_nthreads, 1 != rw_opt_nthreads, > rw_opt_nloops, 1 != rw_opt_nloops); > > > Modified: stdcxx/trunk/tests/localization/22.locale.money.get.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.money.get.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.money.get.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.money.get.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -391,7 +391,7 @@ > > rw_info (0, 0, 0, > "testing std::money_get with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > opt_nthreads, 1 != opt_nthreads, > opt_nloops, 1 != opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.money.put.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.money.put.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.money.put.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.money.put.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -397,7 +397,7 @@ > > rw_info (0, 0, 0, > "testing std::money_put with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > opt_nthreads, 1 != opt_nthreads, > opt_nloops, 1 != opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.moneypunct.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.moneypunct.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.moneypunct.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.moneypunct.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -401,7 +401,7 @@ > > rw_info (0, 0, 0, > "testing std::moneypunct with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > rw_opt_nthreads, 1 != rw_opt_nthreads, > rw_opt_nloops, 1 != rw_opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.num.get.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.num.get.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.num.get.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.num.get.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -474,7 +474,7 @@ > > rw_info (0, 0, 0, > "testing std::num_get with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > rw_opt_nthreads, 1 != rw_opt_nthreads, > rw_opt_nloops, 1 != rw_opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.num.put.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.num.put.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.num.put.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.num.put.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -382,7 +382,7 @@ > > rw_info (0, 0, 0, > "testing std::num_put with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > opt_nthreads, 1 != opt_nthreads, > opt_nloops, 1 != opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.numpunct.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.numpunct.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.numpunct.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.numpunct.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -248,7 +248,7 @@ > > rw_info (0, 0, 0, > "testing std::numpunct with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > opt_nthreads, 1 != opt_nthreads, > rw_opt_nloops, 1 != rw_opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.statics.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.statics.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.statics.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.statics.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -153,7 +153,7 @@ > > rw_info (0, 0, 0, > "testing std::locale::global(const std::locale&) with " > - "%d thread%{?}s%{;}, %zu iteration%{?}s%{;} each, in " > + "%d thread%{?}s%{;}, %d iteration%{?}s%{;} each, in " > "%zu locales { %{ .*A@} }", > opt_nthreads, 1 != opt_nthreads, > opt_nloops, 1 != opt_nloops, > > Modified: stdcxx/trunk/tests/localization/22.locale.time.get.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.time.get.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.time.get.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.time.get.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -441,7 +441,7 @@ > > rw_info (0, 0, 0, > "testing std::time_get with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > rw_opt_nthreads, 1 != rw_opt_nthreads, > rw_opt_nloops, 1 != rw_opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/localization/22.locale.time.put.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/localization/22.locale.time.put.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/localization/22.locale.time.put.mt.cpp (original) > +++ stdcxx/trunk/tests/localization/22.locale.time.put.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -319,7 +319,7 @@ > > rw_info (0, 0, 0, > "testing std::time_put with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > + "%d iteration%{?}s%{;} each, in %zu locales { %{ .*A@} }", > opt_nthreads, 1 != opt_nthreads, > opt_nloops, 1 != opt_nloops, > nlocales, int (nlocales), "%#s", locales); > > Modified: stdcxx/trunk/tests/strings/21.string.cons.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/strings/21.string.cons.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/strings/21.string.cons.mt.cpp (original) > +++ stdcxx/trunk/tests/strings/21.string.cons.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -189,7 +189,7 @@ > { > rw_info (0, 0, 0, > "testing std::string with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each", > + "%d iteration%{?}s%{;} each", > rw_opt_nthreads, 1 != rw_opt_nthreads, > rw_opt_nloops, 1 != rw_opt_nloops); > > @@ -217,7 +217,7 @@ > > rw_info (0, 0, 0, > "testing std::wstring with %d thread%{?}s%{;}, " > - "%zu iteration%{?}s%{;} each", > + "%d iteration%{?}s%{;} each", > rw_opt_nthreads, 1 != rw_opt_nthreads, > rw_opt_nloops, 1 != rw_opt_nloops); > > > Modified: stdcxx/trunk/tests/strings/21.string.push_back.mt.cpp > URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/strings/21.string.push_back.mt.cpp?rev=648131&r1=648130&r2=648131&view=diff > ============================================================================== > --- stdcxx/trunk/tests/strings/21.string.push_back.mt.cpp (original) > +++ stdcxx/trunk/tests/strings/21.string.push_back.mt.cpp Mon Apr 14 23:51:12 2008 > @@ -110,7 +110,7 @@ > static int > run_test (int, char**) > { > - rw_info (0, 0, 0, "running %d thread%{?}s%{;}, %zu iteration%{?}s%{;} each", > + rw_info (0, 0, 0, "running %d thread%{?}s%{;}, %d iteration%{?}s%{;} each", > rw_opt_nthreads, 1 != rw_opt_nthreads, > rw_opt_nloops, 1 != rw_opt_nloops); > > >