incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Lemings" <Eric.Lemi...@roguewave.com>
Subject RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp
Date Wed, 23 Apr 2008 22:11:11 GMT
 

> -----Original Message-----
> From: faridz@apache.org [mailto:faridz@apache.org] 
> Sent: Wednesday, April 23, 2008 9:21 AM
> To: commits@stdcxx.apache.org
> Subject: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp
> 
> Author: faridz
> Date: Wed Apr 23 08:20:07 2008
> New Revision: 650902
> 
> URL: http://svn.apache.org/viewvc?rev=650902&view=rev
> Log:
> 2008-04-23 Farid Zaripov <farid_zaripov@epam.com>
> 
> 	STDCXX-880	
> 	* src/num_put.cpp: Added simple overloads of the 
> __rw_isfinite(),
> 	__rw_signbit(), __rw_isinf(), __rw_isnan(), 
> __rw_isqnan(), __rw_issnan()
> 	for float and long double types.
> 
> Modified:
>     stdcxx/trunk/src/num_put.cpp
> 
> Modified: stdcxx/trunk/src/num_put.cpp
> URL: 
> http://svn.apache.org/viewvc/stdcxx/trunk/src/num_put.cpp?rev=
> 650902&r1=650901&r2=650902&view=diff
> ==============================================================
> ================
> --- stdcxx/trunk/src/num_put.cpp (original)
> +++ stdcxx/trunk/src/num_put.cpp Wed Apr 23 08:20:07 2008
> @@ -181,6 +181,36 @@
>  #endif
>  
>  
> +inline bool __rw_isfinite (float) { return true; }
> +
> +inline bool __rw_signbit (float) { return false; }
> +
> +inline bool __rw_isinf (float) { return false; }
> +
> +inline bool __rw_isnan (float) { return false; }
> +
> +inline bool __rw_isqnan (float) { return false; }
> +
> +inline bool __rw_issnan (float) { return false; }
> +
> +
> +#ifndef _RWSTD_NO_LONG_DOUBLE
> +
> +inline bool __rw_isfinite (long double) { return true; }
> +
> +inline bool __rw_signbit (long double) { return false; }
> +
> +inline bool __rw_isinf (long double) { return false; }
> +
> +inline bool __rw_isnan (long double) { return false; }
> +
> +inline bool __rw_isqnan (long double) { return false; }
> +
> +inline bool __rw_issnan (long double) { return false; }
> +
> +#endif   // _RWSTD_NO_LONG_DOUBLE
> +
> +
>  static int
>  __rw_fmat_infinite (char *buf, size_t bufsize, double val, 
> unsigned flags)
>  {
> 

With just a quick review, this change looks a bit suspicious.  The
respective overloads for type double are all defined within
conditional-compile directives.  It follows that float and long double
overloads would be defined similarly unless I'm missing something.

Brad.

Mime
View raw message