incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [jira] Commented: (STDCXX-866) add 22.locale.ctype.widen.cpp
Date Wed, 30 Apr 2008 20:12:05 GMT
Eric Lemings wrote:
>  
> Should I go ahead and delete the recently added test, close this issue,
> and create a new issue to split the widen/narrow and tolower/toupper
> tests (if there isn't one already)?

If the new test only duplicates what 22.locale.narrow.cpp does
I see no reason to keep it (so yes, I'd delete it and close
the subtask as Invalid or Won't Fix).

If you want to open an issue to split up the existing tests
feel free to do so but unless you take the time to do it
yourself I wouldn't hold my breath that it gets done unless
there's a compelling reason to mess with it (e.g., failures
that are hard to analyze because of the current structure).

Martin

> 
> Brad.
> 
>> -----Original Message-----
>> From: Martin Sebor (JIRA) [mailto:jira@apache.org] 
>> Sent: Wednesday, April 30, 2008 10:20 AM
>> To: issues@stdcxx.apache.org
>> Subject: [jira] Commented: (STDCXX-866) add 22.locale.ctype.widen.cpp
>>
>>
>>     [ 
>> https://issues.apache.org/jira/browse/STDCXX-866?page=com.atla
>> ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focus
>> edCommentId=12593367#action_12593367 ] 
>>
>> Martin Sebor commented on STDCXX-866:
>> -------------------------------------
>>
>> Splitting up the 
>> [22.locale.ctype.narrow.cpp|http://svn.apache.org/repos/asf/st
>> dcxx/trunk/tests/localization/22.locale.ctype.narrow.cpp] 
>> test sounds great but see this 
>> [discussion|http://stdcxx.markmail.org/message/lagbm23t6j5gv7c
>> t] for some of the background on the structure of the test 
>> and why it exercises both functions.
>>
>> As for including the new tests in 4.2.2 (if it happens), I 
>> see no problem with it.
>>
>>> add 22.locale.ctype.widen.cpp
>>> -----------------------------
>>>
>>>                 Key: STDCXX-866
>>>                 URL: 
>> https://issues.apache.org/jira/browse/STDCXX-866
>>>             Project: C++ Standard Library
>>>          Issue Type: Sub-task
>>>          Components: Tests
>>>    Affects Versions: 4.1.2, 4.1.3, 4.1.4, 4.2.0
>>>            Reporter: Martin Sebor
>>>            Assignee: Eric Lemings
>>>             Fix For: 4.2.1
>>>
>>>         Attachments: 22.locale.ctype.widen.cpp, 22_ctype_widen.cpp
>>>
>>>   Original Estimate: 2h
>>>          Time Spent: 1h
>>>  Remaining Estimate: 1h
>>>
>>> The test 22_ctype_widen.cpp needs to be migrated from the 
>> Rogue Wave source code repository into Subversion under the name 
>> [localization/22.locale.ctype.widen.cpp|http://svn.apache.org/
>> repos/asf/stdcxx/trunk/tests/localization/22.locale.ctype.widen.cpp].
>>
>> -- 
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>


Mime
View raw message