incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r643473 - /stdcxx/trunk/tests/support/18.numeric.special.float.cpp
Date Tue, 01 Apr 2008 17:12:48 GMT
elemings@apache.org wrote:
> Author: elemings
> Date: Tue Apr  1 09:40:44 2008
> New Revision: 643473
> 
> URL: http://svn.apache.org/viewvc?rev=643473&view=rev

Brad, a few notes on the format of your Change Log. Our
convention is to use the GNU/Emacs format for Change Logs
described in the Emacs manual:
http://www.gnu.org/software/emacs/manual/html_node/emacs/Change-Log.html#Change-Log

If you use Emacs, the add-change-log-entry command produces
the correct format automatically.

You can see examples of correctly formatted entries in
the ChangeLog file:
http://svn.apache.org/repos/asf/stdcxx/trunk/ChangeLog
for examples.

> Log:
> Tue Apr  1 16:28:22 UTC 2008    Eric Lemings <eric.lemings@roguewave.com>

The date format is YYYY-MM-DD.

> 
> STDCXX-708 <https://issues.apache.org/jira/browse/STDCXX-708>

Each line should be indented by a single TAB. The issue URL
shouldn't be here.

> * tests/support/18.numeric.special.float.cpp:

The names of the function you changed should be listed in
parentheses, like so:

	* tests/support/18.numeric.special.float.cpp
	(limits_values::has_denorm): ...

If your changes are conditional (i.e., based on some preprocessor
macro), you should list the conditional in square brackets before
the list of the functions it applies to, e.g.,

	* tests/support/18.numeric.special.float.cpp
	[_AIX || __hpux] (limits_values::has_denorm): ...

You can correct this Change Log entry via the svn propedit
command, like so:

svn propedit svn:log --revprop -r643473 \
     https://svn.apache.org/repos/asf/stdcxx

Thanks
Martin

> Change expected values for
> std::numeric_limits<FloatT>::has_denorm() to std::denorm_present on all
> HP-UX platforms (inc. PA-RISC and IPF) per comments recorded in the issue.
> 
> 
> Modified:
>     stdcxx/trunk/tests/support/18.numeric.special.float.cpp
> 
> Modified: stdcxx/trunk/tests/support/18.numeric.special.float.cpp
> URL: http://svn.apache.org/viewvc/stdcxx/trunk/tests/support/18.numeric.special.float.cpp?rev=643473&r1=643472&r2=643473&view=diff
> ==============================================================================
> --- stdcxx/trunk/tests/support/18.numeric.special.float.cpp (original)
> +++ stdcxx/trunk/tests/support/18.numeric.special.float.cpp Tue Apr  1 09:40:44 2008
> @@ -451,11 +451,9 @@
>  
>      static std::float_denorm_style has_denorm () {
>  
> -#if defined (_AIX)
> -        return std::denorm_present;
> -#elif defined (__hpux)
> -        return std::denorm_indeterminate;
> -#elif defined (__osf__)
> +#if defined (_AIX) \
> +    || defined (__hpux) \
> +    || defined (__osf__)
>          return std::denorm_present;
>  #else
>          return std::denorm_indeterminate;
> @@ -720,11 +718,9 @@
>  
>  
>      static std::float_denorm_style has_denorm () {
> -#if defined (_AIX)
> -        return std::denorm_present;
> -#elif defined (__hpux)
> -        return std::denorm_indeterminate;
> -#elif defined (__osf__)
> +#if defined (_AIX) \
> +    || defined (__hpux) \
> +    || defined (__osf__)
>          return std::denorm_present;
>  #else
>          return std::denorm_indeterminate;
> @@ -982,11 +978,9 @@
>  
>  
>      static std::float_denorm_style has_denorm () {
> -#if defined (_AIX)
> -        return std::denorm_present;
> -#elif defined (__hpux)
> -        return std::denorm_indeterminate;
> -#elif defined (__osf__)
> +#if defined (_AIX) \
> +    || defined (__hpux) \
> +    || defined (__osf__)
>          return std::denorm_present;
>  #else
>          return std::denorm_indeterminate;
> 
> 


Mime
View raw message