incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Farid Zaripov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (STDCXX-459) time_get::date_order() should return actually date order taken from locale
Date Tue, 18 Dec 2007 19:45:43 GMT

    [ https://issues.apache.org/jira/browse/STDCXX-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552871
] 

Farid Zaripov commented on STDCXX-459:
--------------------------------------

1. This change is not necessary (and even more, it's incorrect, because __rw_get_timepunct()
should be exported if the user instantiates the std::time_get<user_char, user_iterator>).

2. The __rw_get_dateorder() should also be _RWSTD_EXPORT to be accessible from std::time_get<user_char,
user_iterator>. And this change is not a forward binary compatible.

3. I think yes. The outlining doesn't add's the new symbol in the library. The only what may
change - it's a return value from the date_order(). But since the all possible returning values
are valid (the user of the library shouldn't rely on the always returned no_order from date_order())
this change is safe.

> time_get::date_order() should return actually date order taken from locale
> --------------------------------------------------------------------------
>
>                 Key: STDCXX-459
>                 URL: https://issues.apache.org/jira/browse/STDCXX-459
>             Project: C++ Standard Library
>          Issue Type: Improvement
>          Components: 22. Localization
>    Affects Versions: 4.1.2, 4.1.3, 4.1.4
>         Environment: All
>            Reporter: Farid Zaripov
>            Assignee: Farid Zaripov
>            Priority: Minor
>             Fix For: 4.2.1
>
>         Attachments: stdcxx-459.patch
>
>
> The current implementation of the time_get::date_order() always returns no_order. It
should return date order  used by a locale facet (http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg03734.html).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message