incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Sebor (JIRA)" <j...@apache.org>
Subject [jira] Commented: (STDCXX-676) [MSVC] 22.locale.time.put test fails
Date Wed, 05 Dec 2007 05:35:43 GMT

    [ https://issues.apache.org/jira/browse/STDCXX-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548539
] 

Martin Sebor commented on STDCXX-676:
-------------------------------------

I had no idea that C supported only such a small subset of the POSIX directives, or that the
MSVC strftime() was so lame as to support no more than the bare minimum. I should have known
better, or at least looked at the MSVC documentation: http://msdn2.microsoft.com/en-us/library/fe06s4ak(VS.80).aspx

I agree with avoiding using other parts of the library that's being tested. So the only thing
that probably should change about the patch is the preprocessor guard from _WIN32 to _MSC_VER.
Btw., while you're changing it, I noticed the first line of the multiline comments documenting
each directive is missing a space between the comment token and the directive. You might as
well add it while you're making changes.

> [MSVC] 22.locale.time.put test fails
> ------------------------------------
>
>                 Key: STDCXX-676
>                 URL: https://issues.apache.org/jira/browse/STDCXX-676
>             Project: C++ Standard Library
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 4.2.0
>            Reporter: Travis Vitek
>             Fix For: 4.2.1
>
>         Attachments: stdcxx-223.patch
>
>
> In my manual runs I have noticed that the test fails because the MSCRT strftime doesn't
support %T, %e, or %G and asserts internally. This doesn't appear to happen on all configurations
because these tests are running to completion on some of the nightly builds. 
> I think the rw_strftime() that is inside the test could be expanded to avoid the assert
inside the CRT so that the test would pass on all windows configurations. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message