Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 65008 invoked from network); 18 Oct 2007 01:43:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Oct 2007 01:43:05 -0000 Received: (qmail 70375 invoked by uid 500); 18 Oct 2007 01:42:52 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 70355 invoked by uid 500); 18 Oct 2007 01:42:52 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 70344 invoked by uid 99); 18 Oct 2007 01:42:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Oct 2007 18:42:52 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Oct 2007 01:42:56 +0000 Received: from exchmail01.Blue.Roguewave.Com (exchmail01.blue.roguewave.com [10.22.129.22]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l9I1fTHD006835 for ; Thu, 18 Oct 2007 01:41:29 GMT X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] Re: stdcxx 4.2.0/4.1.3 binary incompatibility on Linux Date: Wed, 17 Oct 2007 19:43:11 -0600 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] Re: stdcxx 4.2.0/4.1.3 binary incompatibility on Linux Thread-Index: AcgRJEIpErwXOrdsQYyctM4Moudp/AAARbOA References: <471644A7.9050101@roguewave.com> <47164C7F.5050106@roguewave.com> <471659D7.6020109@roguewave.com> <471694A7.8060009@roguewave.com> <4716AB3A.9060900@roguewave.com> <4716B306.6060009@roguewave.com> From: "Travis Vitek" To: X-Virus-Checked: Checked by ClamAV on apache.org =20 Martin Sebor wrote: > >Travis Vitek wrote: >> =20 >> The only thing I don't like about this patch is that it=20 >> assumes no other platform will exhibit the same behavior >> that we are seeing on Linux/x86_64. I can't say with any >> confidence that things will actually work out that way. >> Personally I'd rather see the change compiled out by >> default on all platforms, and a macro to enable it if >> the user wants it. > >I'm not sure what you mean by "see the change compiled out on all >platforms." Are you saying you want the atomic ops disabled on >all platforms? No, I'm definitely not saying disable atomic ops on all platforms. That would be silly. > The reason for this patch is because the atomic >ops hadn't been ported to x86_64 in time for 4.1.3 (bad mistake): > http://issues.apache.org/jira/browse/STDCXX-162 > Makes sense now. Sorry for the confusion. It has been a long day. >>=20 >> Also, if you want to pick nits, the version check should probably use >> _RWSTD_VER_MAJOR. > >Yes, that would be better. I'll change it. > >Martin > >>=20 >> Travis