incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Travis Vitek" <>
Subject RE: [PATCH] __rw_dbl_infinity ABI change with MSVC
Date Thu, 18 Oct 2007 20:42:37 GMT

Martin Sebor wrote:
>Travis Vitek wrote:
>> Martin Sebor wrote:
>>> Travis, while testing your updated patch, I wonder if it would be
>>> possible to quickly and easily fix STDCXX-509 even for MSVC in
>>> a binary compatible way by using #pragma init_seg to initialize
>>> the constants before any user-defined objects?
>>> Martin
>> Yes, I think this is okay. I've attached a patch that includes this
>> change. I also added a rather ugly macro to use to guard 
>> this stuff to avoid repeating the crazy logic in multiple places.
>Okay, thanks. Now I just need the ChangeLog.

2007-10-18  Travis Vitek  <>

	* rw/_config.h [_RWSTD_VER_MAJOR]: Define macro for workaround
	for binary compatbility issues with msvc.
	* include/limits: Avoid creating binary compatibility issue.
	* src/limits_bits.cpp: Ditto.

>Btw., how did you test this?

I haven't found a way to verify that the symbols are being initialized
at the appropriate time. I have tested the examples on builds of both
msvc-7.1 and msvc-8.0 to verify that I haven't broken anything obvious.

>And did you by any chance apply
>Farid's patch for the exception symbols (with the correction
>for the stdcxx version)?

Yes, the patch for the exception stuff was done seperately.


View raw message