incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Travis Vitek" <tvi...@roguewave.com>
Subject RE: [PATCH] Re: stdcxx 4.2.0/4.1.3 binary incompatibility on Linux
Date Thu, 18 Oct 2007 01:05:58 GMT
 
The only thing I don't like about this patch is that it assumes no other
platform will exhibit the same behavior that we are seeing on
Linux/x86_64. I can't say with any confidence that things will actually
work out that way. Personally I'd rather see the change compiled out by
default on all platforms, and a macro to enable it if the user wants it.

Also, if you want to pick nits, the version check should probably use
_RWSTD_VER_MAJOR.

Travis

>-----Original Message-----
>From: Martin Sebor [mailto:sebor@roguewave.com] 
>Sent: Wednesday, October 17, 2007 5:39 PM
>To: stdcxx-dev@incubator.apache.org
>Subject: [PATCH] Re: stdcxx 4.2.0/4.1.3 binary incompatibility on Linux
>
>How does the attached patch look?
>
>The patch adds two macros, _RWSTD_NO_STRING_ATOMIC_OPS and
>_RWSTD_USE_STRING_ATOMIC_OPS. The first one is #defined for
>all compilers on Linux/x86_64 (i.e., in wide mode), *unless*
>the second one is defined, either on the command line on in
>the generated config header by the user. This whole hackery
>is guarded by _RWSTD_VER and automatically disabled (i.e.,
>the library switches over to using atomic operations by
>default) at version 5.
>
>Martin
>

Mime
View raw message