incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r586502 - /incubator/stdcxx/branches/4.2.0/include/rw/_config-msvcrt.h
Date Fri, 19 Oct 2007 16:56:54 GMT
Farid Zaripov wrote:
>> -----Original Message-----
>> From: Martin Sebor [mailto:sebor@roguewave.com] 
>> Sent: Friday, October 19, 2007 7:40 PM
>> To: stdcxx-dev@incubator.apache.org
>> Subject: Re: svn commit: r586502 - 
>> /incubator/stdcxx/branches/4.2.0/include/rw/_config-msvcrt.h
>>
>>>   I think we can also include the following patch in 4.2.0 release:
>>>
>> http://www.nabble.com/__rw_once-warnings-in-non-reentrant-Windows-buil
>>> ds
>>> --tf4634599.html#a13295746
>> This makes it possible to do non-reentrant builds with MSVC 8 
>> just like with MSVC 7, correct? I.e., it makes the 8s and 11s 
>> build types non-reentrant when using MSVC 8, as they are in 
>> stdcxx 4.1.3 (when using MSVC 7).
> 
>   Yes. This patch puts in config.h _RWSTD_NO_REENTRANT macro at
> configuration step. And then if this macro is defined, then
> _RWSTD_REENTRANT
> macro will not be defined or undefined (if it already defined) in
> _config-msvcrt.h.
> 
>>  If you're comfortable that 
>> the patch is good for all compilers and build types I have no 
>> objection. Does anyone have a problem with this?
> 
>   This patch affects only MSVC and ICC/Windows compilers.

Right, that's what I meant, but we have a number of them on
our test matrix (MSVC 7.1, 8.0, and the 9.0 beta, and Intel
C++ 9.1 and 10). I'm looking for assurance that the patch
won't break any of them, in any configuration (build type).

Martin

Mime
View raw message