Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 62413 invoked from network); 27 Sep 2007 12:59:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Sep 2007 12:59:40 -0000 Received: (qmail 91877 invoked by uid 500); 27 Sep 2007 12:59:30 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 91815 invoked by uid 500); 27 Sep 2007 12:59:30 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 91804 invoked by uid 99); 27 Sep 2007 12:59:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Sep 2007 05:59:30 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of Farid_Zaripov@epam.com designates 217.21.63.3 as permitted sender) Received: from [217.21.63.3] (HELO EPMSA009.epam.com) (217.21.63.3) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Sep 2007 13:01:51 +0000 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C80106.321DCC7D" Subject: [PATCH] time_put.cpp Date: Thu, 27 Sep 2007 15:59:06 +0300 Message-ID: <7BDB2168BEAEF14C98F1901FD2DE643801009579@epmsa009.minsk.epam.com> X-MS-Has-Attach: yes X-MS-TNEF-Correlator: Thread-Topic: [PATCH] time_put.cpp Thread-Index: AcgBBi/q7n2wvFkvRi2lWnu1pAVuNQ== From: "Farid Zaripov" To: X-Virus-Checked: Checked by ClamAV on apache.org ------_=_NextPart_001_01C80106.321DCC7D Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The MSVC issues parameter validation error in 22.locale.time.put.mt.cpp test. The parameter checking code below: --------- int (isspace) (int c) { _ASSERTE((unsigned)(c + 1) <=3D 256); ... } --------- The same validation performed in all isxxx() functions. This validation asserts on all c < -1. The patch is attached. ChangeLog: * time_put.cpp (__rw_get_date_fmat): Convert char argument of isspace(), isdigit(), ispunct() to unsigned char . (__rw_get_time_fmat): Ditto. Farid. ------_=_NextPart_001_01C80106.321DCC7D Content-Type: text/plain; name="time_put.cpp.diff.txt" Content-Transfer-Encoding: base64 Content-Description: time_put.cpp.diff.txt Content-Disposition: attachment; filename="time_put.cpp.diff.txt" SW5kZXg6IHRpbWVfcHV0LmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIHRpbWVfcHV0LmNwcAkocmV2aXNp b24gNTc5ODk4KQ0KKysrIHRpbWVfcHV0LmNwcAkod29ya2luZyBjb3B5KQ0KQEAgLTE2MCw2ICsx NjAsNyBAQA0KIAogI2lmZGVmIF9SV1NURF9OT19OTF9MQU5HSU5GTwogCit0eXBlZGVmIHVuc2ln bmVkIGNoYXIgVUNoYXI7CiAKIC8vIGNvbXB1dGUgdGhlIGZvcm1hdCBzdHJpbmcgY29ycmVzcG9u ZGluZyB0byB0aGUgIiV4IiBmb3JtYXQgc3BlY2lmaWVyCiAvLyBpbiB0aGUgY3VycmVudCBsb2Nh bGUgKHNldCBieSBzZXRsb2NhbGUgKExDX0FMTCwgLi4uKSkKQEAgLTE5NywxNiArMTk4LDE2IEBA DQogICAgIGZvciAoY2hhciAqcHRtcCA9IHRtcDsgKnB0bXA7ICkgewogCiAgICAgICAgIC8vIHN0 b3JlIGFsbCB3aGl0ZXNwYWNlIGFzIHBhcnQgb2YgZm9ybWF0Ci0gICAgICAgIGZvciAoOyAoaXNz cGFjZSkoKnB0bXApOyArK3B0bXApCisgICAgICAgIGZvciAoOyAoaXNzcGFjZSkoVUNoYXIgKCpw dG1wKSk7ICsrcHRtcCkKICAgICAgICAgICAgICpwZm10KysgPSAqcHRtcDsKIAogICAgICAgICBj b25zdCBjaGFyICpiZWdpbiA9IHB0bXA7CiAKICAgICAgICAgLy8gc2tpcCBvdmVyIGFsbCBub24t ZGlnaXQgY2hhcmFjdGVycwotICAgICAgICBmb3IgKDsgKnB0bXAgJiYgIShpc2RpZ2l0KSgqcHRt cCk7ICsrcHRtcCkgewotICAgICAgICAgICAgaWYgKChpc3B1bmN0KSgqcHRtcCkgfHwgKGlzc3Bh Y2UpKCpwdG1wKSkgeworICAgICAgICBmb3IgKDsgKnB0bXAgJiYgIShpc2RpZ2l0KShVQ2hhciAo KnB0bXApKTsgKytwdG1wKSB7CisgICAgICAgICAgICBpZiAoKGlzcHVuY3QpKFVDaGFyICgqcHRt cCkpIHx8IChpc3NwYWNlKShVQ2hhciAoKnB0bXApKSkgewogICAgICAgICAgICAgICAgIC8vIHN0 b3JlIGFsbCBwdW5jdHVhdG9ycyBhcyBwYXJ0IG9mIGZvcm1hdAotICAgICAgICAgICAgICAgIGZv ciAoIDsgKGlzcHVuY3QpKCpwdG1wKSB8fCAoaXNzcGFjZSkoKnB0bXApOyArK3B0bXApCisgICAg ICAgICAgICAgICAgZm9yICggOyAoaXNwdW5jdCkoVUNoYXIgKCpwdG1wKSkgfHwgKGlzc3BhY2Up KFVDaGFyICgqcHRtcCkpOyArK3B0bXApCiAgICAgICAgICAgICAgICAgICAgICpwZm10KysgPSAq cHRtcDsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KQEAgLTI1OCw5ICsy NTksOSBAQA0KICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAgIGlmICgoaXNkaWdp dCkoKnB0bXApKSB7CisgICAgICAgIGlmICgoaXNkaWdpdCkoVUNoYXIgKCpwdG1wKSkpIHsKIAot ICAgICAgICAgICAgZm9yIChiZWdpbiA9IHB0bXA7IChpc2RpZ2l0KSgqcHRtcCk7ICsrcHRtcCk7 CisgICAgICAgICAgICBmb3IgKGJlZ2luID0gcHRtcDsgKGlzZGlnaXQpKFVDaGFyICgqcHRtcCkp OyArK3B0bXApOwogCiAgICAgICAgICAgICAqcGZtdCsrID0gJyUnOwogICAgICAgICAgICAgaWYg KHB0bXAgLSBiZWdpbiA9PSAxKSB7CkBAIC0zMjIsMTYgKzMyMywxNiBAQA0KIAogICAgIGZvciAo Y2hhciAqcHRtcCA9IHRtcDsgKnB0bXA7ICkgewogCi0gICAgICAgIGZvciAoOyAoaXNzcGFjZSko KnB0bXApOyArK3B0bXApCisgICAgICAgIGZvciAoOyAoaXNzcGFjZSkoVUNoYXIgKCpwdG1wKSk7 ICsrcHRtcCkKICAgICAgICAgICAgICpwZm10KysgPSAqcHRtcDsKIAogICAgICAgICBjb25zdCBj aGFyICpiZWdpbiA9IHB0bXA7CiAKLSAgICAgICAgZm9yICg7ICpwdG1wICYmICEoaXNkaWdpdCko KnB0bXApOyArK3B0bXApIHsKLSAgICAgICAgICAgIGlmICggICAoaXNwdW5jdCkoKnB0bXApCi0g ICAgICAgICAgICAgICAgfHwgKGlzc3BhY2UpKCpwdG1wKSkgewotICAgICAgICAgICAgICAgIGZv ciAoOyAgICAoaXNwdW5jdCkoKnB0bXApCi0gICAgICAgICAgICAgICAgICAgICAgIHx8IChpc3Nw YWNlKSgqcHRtcCk7ICsrcHRtcCkKKyAgICAgICAgZm9yICg7ICpwdG1wICYmICEoaXNkaWdpdCko VUNoYXIgKCpwdG1wKSk7ICsrcHRtcCkgeworICAgICAgICAgICAgaWYgKCAgIChpc3B1bmN0KShV Q2hhciAoKnB0bXApKQorICAgICAgICAgICAgICAgIHx8IChpc3NwYWNlKShVQ2hhciAoKnB0bXAp KSkgeworICAgICAgICAgICAgICAgIGZvciAoOyAgICAoaXNwdW5jdCkoVUNoYXIgKCpwdG1wKSkK KyAgICAgICAgICAgICAgICAgICAgICAgfHwgKGlzc3BhY2UpKFVDaGFyICgqcHRtcCkpOyArK3B0 bXApCiAgICAgICAgICAgICAgICAgICAgICpwZm10KysgPSAqcHRtcDsKICAgICAgICAgICAgICAg ICBicmVhazsKICAgICAgICAgICAgIH0KQEAgLTM1OSw5ICszNjAsOSBAQA0KICAgICAgICAgICAg IH0KICAgICAgICAgfQogCi0gICAgICAgIGlmICgoaXNkaWdpdCkoKnB0bXApKSB7CisgICAgICAg IGlmICgoaXNkaWdpdCkoVUNoYXIgKCpwdG1wKSkpIHsKIAotICAgICAgICAgICAgZm9yIChiZWdp biA9IHB0bXA7IChpc2RpZ2l0KSgqcHRtcCk7ICsrcHRtcCk7CisgICAgICAgICAgICBmb3IgKGJl Z2luID0gcHRtcDsgKGlzZGlnaXQpKFVDaGFyICgqcHRtcCkpOyArK3B0bXApOwogCiAgICAgICAg ICAgICAqcGZtdCsrID0gJyUnOwogCg== ------_=_NextPart_001_01C80106.321DCC7D--