Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 43769 invoked from network); 13 Aug 2007 18:00:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Aug 2007 18:00:40 -0000 Received: (qmail 60693 invoked by uid 500); 13 Aug 2007 18:00:37 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 60683 invoked by uid 500); 13 Aug 2007 18:00:37 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 60661 invoked by uid 99); 13 Aug 2007 18:00:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Aug 2007 11:00:37 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Aug 2007 18:00:33 +0000 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l7DI0BTf004718 for ; Mon, 13 Aug 2007 18:00:12 GMT X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] Update test 22.locale.time.put.mt.cpp to validate results [take 2] Date: Mon, 13 Aug 2007 11:59:24 -0600 Message-ID: In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] Update test 22.locale.time.put.mt.cpp to validate results [take 2] Thread-Index: AcfdNNhyDTSg1TutQISJTaLj+15eSQAk0BtQAAJwojA= References: <46BF913F.8000403@roguewave.com> From: "Travis Vitek" To: X-Virus-Checked: Checked by ClamAV on apache.org =20 Travis Vitek wrote: > >Martin Sebor wrote: >> >>What do you think about this: let's change rw_locales() to always >>return a list of names that starts with "C". That way callers that >>don't want to exercise the "C" locale can simply skip past it while >>others will be guaranteed to exercise the classic locale. >> >Sounds good. If we all agee, then I'll make up a patch for rw_locales() >and for each of the tests that I added last week. > >I'm thinking that rw_locales should take a bool that indicates the "C" >locale should be included at the head of the list. Ideally the default >value would be true, but for compatibility it should be set to false. >Hmmm. I'm thinking false and the tests that want the new=20 >behavior can be >updated later. > >I will also need to add support for a command line option to enable or >disable this behavior. I'm thinking --use-c-locale=3D# or = --no-c-locale# >depending on what we decide for the default value mentioned above. Does >that sound okay? Ugh. What if the user provides both options --locales=3Den_US,es_MX and --use-c-locale? Should we attempt to add the "C" locale to the user supplied locale list, or should this only be something that is in effect when the user doesn't use --locales? The second option is weird, but it makes the most sense. The user could easily just write --locales=3Den_US,es_MX,C if that is what they wanted. In either case it looks like I might need to make a function in test/rw_locale.h that provides some documentation and sets a flag that is used by rw_locales(). > >>Martin >> >> >