Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 66700 invoked from network); 8 Aug 2007 23:51:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Aug 2007 23:51:47 -0000 Received: (qmail 44253 invoked by uid 500); 8 Aug 2007 23:51:45 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 44232 invoked by uid 500); 8 Aug 2007 23:51:45 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 44221 invoked by uid 99); 8 Aug 2007 23:51:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2007 16:51:45 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2007 23:51:41 +0000 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l78NpJUa004849 for ; Wed, 8 Aug 2007 23:51:19 GMT X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] Update test 22.locale.time.put.mt.cpp to validate results Date: Wed, 8 Aug 2007 17:50:56 -0600 Message-ID: In-Reply-To: <46BA3E5B.1080700@roguewave.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] Update test 22.locale.time.put.mt.cpp to validate results Thread-Index: AcfaCHs1iI17UqmfRda+Ne3tj+b4ZwADeteg References: <46B8A1D6.8050706@roguewave.com> <46B90C21.8060108@roguewave.com> <46B944ED.10602@roguewave.com> <46BA3E5B.1080700@roguewave.com> From: "Travis Vitek" To: X-Virus-Checked: Checked by ClamAV on apache.org =20 Martin Sebor wrote: > >You mean when the user specifies --locales=3D"foo bar" and one or >more of them isn't available the test should give an error? Hmm, >I agree that we should give some indication that one (or more) >of the locales are unavailable in this case but think I would >still prefer a warning to a hard error, simply because I see no >harm in being robust (not every locale that /usr/bin/locale -a >spits out is valid, so having the test weed out the bad ones >can be useful when scripting things). Do you have a reason for >wanting it to be an error? > Exactly. I'm okay with a warning. I'm considering adding a warning for each locale that couldn't be loaded. If no usable locale is available, I will issue another warning that the 'C' locale will be used. > >The API is the same. The machinery is enabled automatically by >pointing the RWSTD_LOCALE_ROOT environment variable at the root >of the stdcxx locale database tree and referencing locales >installed under it by name (or pathname). Most of the locale >tests, including 22.locale.time.put.cpp, exercise both >implementations. I'll add this to my todo list. Right now I think it is best if I get some commitable tests written. :) > >Martin >