incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Travis Vitek" <>
Subject RE: [PATCH] Update test to validate results
Date Wed, 08 Aug 2007 21:48:53 GMT

Martin Sebor wrote:
>A test failure should indicate that there is a problem with 
>the library,
>not that the environment system is not equipped to exercise it.


>there's only one locale installed on a system (the "C" locale must
>always be present) that's not a problem we can do much about. All it
>means is that we can't tell if the library would work correctly if
>there were more than one locale. So I think in this case the test
>should just run all threads in the "C" locale. It won't be a very
>useful test but it'll be better than nothing, don't you agree?

The only issue I would have is when the test is run manually. There
is a command line argument to explicitly specify the locales to use,
and if none of them are available I think I'd expect the test to exit
immediately with an error.

I can live with defaulting to the C locale as long as there is a
warning, which is already provided.

>Btw., the locale thread safety tests currently only exercise the
>implementation when using the native (libc) locales. There's a big
>chunk of code that deals with our own locales that's not being
>tested. At some point we'll need to enhance the tests to exercise
>this functionality as well.

I'm not sure what needs to be added for this enhancement. Could you
name a test or two that does this, or point me to the APIs I need
to be using?


View raw message