incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Farid Zaripov" <Farid_Zari...@epam.com>
Subject RE: missprint in include/rw/_mutex.h ?
Date Fri, 10 Aug 2007 16:07:02 GMT
> -----Original Message-----
> From: Martin Sebor [mailto:sebor@roguewave.com] 
> Sent: Friday, August 10, 2007 6:59 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: missprint in include/rw/_mutex.h ?
> 
> Farid Zaripov wrote:
> >   Below is a part of the include/rw/_mutex.h file, line 116:
> > 
> > -----------
> > #  ifdef _RWSTD_NO_FWD_DECLARATIONS
> >  
> > #    include <windows.h>
> > #    define _RWSTD_MUTEX_T _RTL_CRITICAL_SECTION
> >  
> > #  else   // if defined (_RWSTD_NO_FWD_DECLARATIONS)
> >  
> >    // avoid #including this header (MFC doesn't like it)
> >    // #  include <windows.h>
> > -----------
> > 
> >   Perhaps there in the first line should be #ifndef instead 
> of #ifdef ?
> 
> What makes you think that?

  Just from comment in #else :)

 #  ifdef _RWSTD_NO_FWD_DECLARATIONS
 #  else   // if defined (_RWSTD_NO_FWD_DECLARATIONS)

  I thought that froward declaration is the #including <windows.h>,
but now I understand that is conversely declaring the function
prototypes instead of #including <windows.h>.

  The comment on #else should be // if !defined
(_RWSTD_NO_FWD_DECLARATIONS)

Farid.

Mime
View raw message