Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of Farid_Zaripov@epam.com
 designates 217.21.63.3 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: MyStreambuf class is incomplete
Date: Thu, 19 Jul 2007 17:46:05 +0300
Message-ID: <7BDB2168BEAEF14C98F1901FD2DE6438B00C7E@epmsa009.minsk.epam.com>
In-Reply-To: <469D93F5.1050200@roguewave.com>
Thread-Topic: MyStreambuf class is incomplete
Thread-Index: AcfI8qLm6cHVXBPcRXSFPBLbrveG6ABBxlOg
References: <7BDB2168BEAEF14C98F1901FD2DE6438B00502@epmsa009.minsk.epam.com>
 <469D93F5.1050200@roguewave.com>
From: "Farid Zaripov" <Farid_Zaripov@epam.com>
To: <stdcxx-dev@incubator.apache.org>

> -----Original Message-----
> From: Martin Sebor [mailto:msebor@gmail.com] On Behalf Of Martin Sebor
> Sent: Wednesday, July 18, 2007 7:16 AM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: MyStreambuf class is incomplete
>=20
> Farid Zaripov wrote:
> >   The throw_when_ mebmer of the MyStreambuf class=20
> (rw_streambuf.h line
> > 183) is
> > not initialized at the moment in class ctor's (only=20
> zero'ed), but used=20
> > in
> > MyStreambuf::test() (lines 472, 483). I suppose that this class=20
> > designed to initialize throw_when_ within test functions.=20
> But for now=20
> > the all iostream tests doesn't do it.
> > Maybe we just remove this mebmer at all? The patch is ready :)
>=20
> I'm not dead set against removing it but if it ain't broke...?
> Is it actually causing problems or are you just cleaning things up?

  It causing problems because the tests are uses fail_when parameter to
set when
MyStreambuf should to throw, but MyStreambuf throws only if throw_when_
[inx] =3D=3D callno.
So we should to apply my patch (remove throw_when_ and throw when
fail_when_ =3D=3D callno,
or modify all tests to set throw_when_[] array.

Farid.