From stdcxx-dev-return-3857-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Tue Jul 03 04:27:42 2007 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 2927 invoked from network); 3 Jul 2007 04:27:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jul 2007 04:27:42 -0000 Received: (qmail 2658 invoked by uid 500); 3 Jul 2007 04:27:45 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 2644 invoked by uid 500); 3 Jul 2007 04:27:45 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 2633 invoked by uid 99); 3 Jul 2007 04:27:45 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2007 21:27:45 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of msebor@gmail.com designates 64.233.162.230 as permitted sender) Received: from [64.233.162.230] (HELO nz-out-0506.google.com) (64.233.162.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2007 21:27:41 -0700 Received: by nz-out-0506.google.com with SMTP id o37so1176297nzf for ; Mon, 02 Jul 2007 21:27:21 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:organization:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; b=Wdg9KjmXFzoOekbBOKyyWshMqnmfcnudqU9ezK9qWjyAEMBkceyqxMVs0ULJlGg4HJ9S6ISaBUW9mE0ALJTooujhEHgA5nOazkAAJmrCm6A7ch27fliRrEhm96GVKRUtu3sIHC2Iw5g70VH6tQKzPDLE3AblOKt7fD8p7wsJexc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:organization:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; b=fQ2xBDASZiBxXBbixC+FYwo9nB8roZmdYONjOAOmPySd5zFRiUmpZeQsazG5cmZBIbVLD0DWOEc27cGZSleKrg7kHwK+y7Wece9tZeAlBP67rljb00mf7Ba2vammcD4zJ1mDCkJYxSOHGvxgaNzLm3CHrjgNV6bNTA+OzBdgofY= Received: by 10.114.169.2 with SMTP id r2mr5807568wae.1183436840062; Mon, 02 Jul 2007 21:27:20 -0700 (PDT) Received: from ?192.168.1.104? ( [71.229.200.170]) by mx.google.com with ESMTP id q18sm28311572pog.2007.07.02.21.27.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 02 Jul 2007 21:27:16 -0700 (PDT) Message-ID: <4689D023.7020301@roguewave.com> Date: Mon, 02 Jul 2007 22:27:15 -0600 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.12) Gecko/20070531 Fedora/1.0.9-1.fc6 pango-text SeaMonkey/1.0.9 MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: svn commit: r546535 - /incubator/stdcxx/trunk/include/sstream References: <20070612153921.6EF471A981C@eris.apache.org> In-Reply-To: <20070612153921.6EF471A981C@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: Martin Sebor X-Virus-Checked: Checked by ClamAV on apache.org faridz@apache.org wrote: > Author: faridz > Date: Tue Jun 12 08:39:20 2007 > New Revision: 546535 > > URL: http://svn.apache.org/viewvc?view=rev&rev=546535 > Log: > 2007-06-12 Farid Zaripov > > * sstream (str): Method definition moved outside of the class definition. > > Modified: > incubator/stdcxx/trunk/include/sstream > > Modified: incubator/stdcxx/trunk/include/sstream > URL: http://svn.apache.org/viewvc/incubator/stdcxx/trunk/include/sstream?view=diff&rev=546535&r1=546534&r2=546535 > ============================================================================== > --- incubator/stdcxx/trunk/include/sstream (original) > +++ incubator/stdcxx/trunk/include/sstream Tue Jun 12 08:39:20 2007 [...] > @@ -194,6 +177,28 @@ > void _C_catchup (char_type*); > }; > > +template > +inline basic_string<_CharT, _Traits, _Allocator> > +basic_stringbuf<_CharT, _Traits, _Allocator>:: > +str () const { In member functions defined outside the definition of their class the opening brace goes on a line all by itself. It's also nice to separate namespace-scope definitions by two blank lines rather than just one (it makes it easier to tell individual function definitions apart). > + > + const char_type * __first = 0; > + const char_type * __last = 0; There should be a space only on one side of the asterisk, not both. I.e., like this: const char_type* __first = 0; const char_type* __last = 0; I made the changes here: http://svn.apache.org/viewvc?view=rev&rev=552661 Martin