Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 78131 invoked from network); 26 Jun 2007 15:37:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Jun 2007 15:37:22 -0000 Received: (qmail 22509 invoked by uid 500); 26 Jun 2007 15:37:25 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 22497 invoked by uid 500); 26 Jun 2007 15:37:25 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 22486 invoked by uid 99); 26 Jun 2007 15:37:25 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jun 2007 08:37:25 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jun 2007 08:37:21 -0700 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l5QFaxD3015235 for ; Tue, 26 Jun 2007 15:36:59 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 26 Jun 2007 09:35:34 -0600 Message-ID: <46813330.9010203@roguewave.com> Date: Tue, 26 Jun 2007 09:39:28 -0600 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2) Gecko/20070221 SeaMonkey/1.1.1 MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: svn commit: r550545 - in /incubator/stdcxx/trunk/tests/localization: 22.locale.ctype.is.cpp 22.locale.ctype.narrow.cpp 22.locale.ctype.scan.cpp 22.locale.ctype.tolower.cpp 22.locale.ctype.toupper.cpp References: <20070625165011.F03841A981D@eris.apache.org> <46800B88.7090109@roguewave.com> <7BDB2168BEAEF14C98F1901FD2DE64389D6DD3@epmsa009.minsk.epam.com> In-Reply-To: <7BDB2168BEAEF14C98F1901FD2DE64389D6DD3@epmsa009.minsk.epam.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 26 Jun 2007 15:35:34.0272 (UTC) FILETIME=[A3062800:01C7B807] X-Virus-Checked: Checked by ClamAV on apache.org Farid Zaripov wrote: >> -----Original Message----- >> From: Martin Sebor [mailto:sebor@roguewave.com] >> Sent: Monday, June 25, 2007 9:38 PM >> To: stdcxx-dev@incubator.apache.org >> Subject: Re: svn commit: r550545 - in >> /incubator/stdcxx/trunk/tests/localization: >> 22.locale.ctype.is.cpp 22.locale.ctype.narrow.cpp >> 22.locale.ctype.scan.cpp 22.locale.ctype.tolower.cpp >> 22.locale.ctype.toupper.cpp >> >> faridz@apache.org wrote: >>> Author: faridz >>> Date: Mon Jun 25 09:50:10 2007 >>> New Revision: 550545 >> Thanks for taking care of this! IIRC, you made a similar >> change before, suggesting the rw_locales() API is >> error-prone. I wonder if we should change it so as to return >> "" instead of 0 on error. >> >> Incidentally, why does it fail in your environment? > > When I run the test only, the locale.exe utility not in the path > and then the rw_locales() returns NULL. And later when the test > iterating through the list I got access violation. > > I aggree to change rw_locales() to return something but not NULL. > Perhaps rw_locales() should return "C"? I assume that "C" locale is > always available, isn't it? Yes, it is. That might make more sense than returning "". Actually, it will need to be "C\0", i.e., there must be two NULs at the end of the string. Martin