Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <467BFAAF.6000206@roguewave.com>
Date: Fri, 22 Jun 2007 10:37:03 -0600
From: Martin Sebor <sebor@roguewave.com>
Organization: Rogue Wave Software
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
 rv:1.8.1.2) Gecko/20070221 SeaMonkey/1.1.1
MIME-Version: 1.0
To: stdcxx-dev@incubator.apache.org
Subject: Re: svn commit: r549766 - in /incubator/stdcxx/trunk:
 examples/manual/rwexcept.cpp
 include/rw/_error.h src/exception.cpp
References: <20070622101553.2DD041A981A@eris.apache.org>
 <467BECBE.4040908@roguewave.com>
 <7BDB2168BEAEF14C98F1901FD2DE64389D6972@epmsa009.minsk.epam.com>
In-Reply-To: <7BDB2168BEAEF14C98F1901FD2DE64389D6972@epmsa009.minsk.epam.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Farid Zaripov wrote:
>> -----Original Message-----
>> From: Martin Sebor [mailto:sebor@roguewave.com] 
>> Sent: Friday, June 22, 2007 6:38 PM
>> To: stdcxx-dev@incubator.apache.org
>> Subject: Re: svn commit: r549766 - in 
>> /incubator/stdcxx/trunk: examples/manual/rwexcept.cpp 
>> include/rw/_error.h src/exception.cpp
>>
> 
> [...]
> 
>>  From 7.1.2, p4: "If a function with external linkage is 
>> declared inline in one translation unit, it shall be declared 
>> inline in all translation units in which it appears; no 
>> diagnostic is required."
>>
>> Also, I think the convention used in the rest of the code is 
>> to put _RWSTD_EXPORT before the return type of the function, 
>> but you might want to double-check that. Either way, it 
>> should be consistent between the declaration and the 
>> definition of the function.
> 
>   Done: http://svn.apache.org/viewvc?view=rev&rev=549862

Sorry, this violates the last sentence of 3.2, p3:

     An inline function shall be defined in every translation
     unit in which it is used.

Martin