incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Farid Zaripov" <Farid_Zari...@epam.com>
Subject RE: STD_BAD_ALLOC.cpp test problem on Windows
Date Mon, 25 Jun 2007 14:49:17 GMT
> -----Original Message-----
> From: Martin Sebor [mailto:msebor@gmail.com] On Behalf Of Martin Sebor
> Sent: Tuesday, June 19, 2007 6:52 AM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: STD_BAD_ALLOC.cpp test problem on Windows
> 
> I think this will work.
> 
> Just as a side-note (I think you're handling this case 
> safely) there is a potential problem here since headers 
> aren't checked for dependencies on config macros and so 
> testing their value in them is unsafe unless it has been 
> first tested in the .cpp file that #includes the header. The 
> duplication can lead to hard to find errors.
> 
> So while your changes are safe (AFAICT) I would suggest a 
> comment just before the #include directive for proclimits.h 
> mentioning this caveat and a similar one in the header itself.

  Done: http://svn.apache.org/viewvc?view=rev&rev=548616

Farid.

Mime
View raw message