incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r549766 - in /incubator/stdcxx/trunk: examples/manual/rwexcept.cpp include/rw/_error.h src/exception.cpp
Date Fri, 22 Jun 2007 16:37:03 GMT
Farid Zaripov wrote:
>> -----Original Message-----
>> From: Martin Sebor [mailto:sebor@roguewave.com] 
>> Sent: Friday, June 22, 2007 6:38 PM
>> To: stdcxx-dev@incubator.apache.org
>> Subject: Re: svn commit: r549766 - in 
>> /incubator/stdcxx/trunk: examples/manual/rwexcept.cpp 
>> include/rw/_error.h src/exception.cpp
>>
> 
> [...]
> 
>>  From 7.1.2, p4: "If a function with external linkage is 
>> declared inline in one translation unit, it shall be declared 
>> inline in all translation units in which it appears; no 
>> diagnostic is required."
>>
>> Also, I think the convention used in the rest of the code is 
>> to put _RWSTD_EXPORT before the return type of the function, 
>> but you might want to double-check that. Either way, it 
>> should be consistent between the declaration and the 
>> definition of the function.
> 
>   Done: http://svn.apache.org/viewvc?view=rev&rev=549862

Sorry, this violates the last sentence of 3.2, p3:

     An inline function shall be defined in every translation
     unit in which it is used.

Martin

Mime
View raw message