Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 9968 invoked from network); 29 May 2007 20:27:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 29 May 2007 20:27:56 -0000 Received: (qmail 76441 invoked by uid 500); 29 May 2007 20:28:00 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 76383 invoked by uid 500); 29 May 2007 20:28:00 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 76372 invoked by uid 99); 29 May 2007 20:28:00 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 May 2007 13:28:00 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 May 2007 13:27:55 -0700 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l4TKQvHd023559 for ; Tue, 29 May 2007 20:26:57 GMT Received: from [192.168.40.101] ([10.22.130.208]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 29 May 2007 14:26:58 -0600 In-Reply-To: <465C85E2.6070402@roguewave.com> References: <465118A9.30407@roguewave.com> <0B39DB22-C426-48B3-AAA2-560AF5F4FE70@roguewave.com> <46522879.6090409@roguewave.com> <4B2DED28-7166-4FB8-825A-DDC9978EB505@roguewave.com> <465C52AC.4050601@roguewave.com> <465C6C67.70100@roguewave.com> <465C85E2.6070402@roguewave.com> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Liviu Nicoara Subject: Re: Intel Thread Checker Support Date: Tue, 29 May 2007 16:27:36 -0400 To: stdcxx-dev@incubator.apache.org X-Mailer: Apple Mail (2.752.3) X-OriginalArrivalTime: 29 May 2007 20:26:58.0686 (UTC) FILETIME=[B4FB01E0:01C7A22F] X-Virus-Checked: Checked by ClamAV on apache.org On May 29, 2007, at 3:58 PM, Martin Sebor wrote: > Liviu Nicoara wrote: >> Liviu Nicoara wrote: >>> Liviu Nicoara wrote: >>>> On May 21, 2007, at 7:17 PM, Martin Sebor wrote: >>>>> There is a problem in locale (as usual, sigh :( A couple of our >>>>> thread safety tests have been crashing: 22_mt and 22_time_put_mt. >> FWIW, the run of the 4.1.4-rel branch of locale/mt.cpp... >> A quick glance over the places in the analysis report shows >> unguarded rw accesses to certain memory locations (used to store >> facets?). I am not sure though whether this access is >> intentionally unguarded or not. > > They do look unguarded but I don't think I would describe > them as bugs given the "loose" rules for thread safety we > follow in stdcxx (we make assumptions about ordering and > visibility that aren't guaranteed to hold in general but > typically do in our experience). Yep, I know. > And since we don't even > have tests for all our thread-safety sensitive code we'd > also need to add some. They wouldn't be too difficult to > write. I'd say we should be able to add tests for all of > locale in a week, and then take another week to clean up > all the errors. That's great. I could run the ITC tool on stdcxx sources afterwards and use those results as a starting point in adding the code to silence the errors -- assuming there're going to be any left in that part of the code. Liviu