incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Liviu Nicoara <>
Subject Re: Intel Thread Checker Support
Date Tue, 29 May 2007 20:27:36 GMT
On May 29, 2007, at 3:58 PM, Martin Sebor wrote:

> Liviu Nicoara wrote:
>> Liviu Nicoara wrote:
>>> Liviu Nicoara wrote:
>>>> On May 21, 2007, at 7:17 PM, Martin Sebor wrote:
>>>>> There is a problem in locale (as usual, sigh :( A couple of our
>>>>> thread safety tests have been crashing: 22_mt and 22_time_put_mt.

>> FWIW, the run of the 4.1.4-rel branch of locale/mt.cpp...
>> A quick glance over the places in the analysis report shows  
>> unguarded rw accesses  to certain memory locations (used to store  
>> facets?). I am not sure though whether this access is  
>> intentionally unguarded or not.
> They do look unguarded but I don't think I would describe
> them as bugs given the "loose" rules for thread safety we
> follow in stdcxx (we make assumptions about ordering and
> visibility that aren't guaranteed to hold in general but
> typically do in our experience).

Yep, I know.

> And since we don't even
> have tests for all our thread-safety sensitive code we'd
> also need to add some. They wouldn't be too difficult to
> write. I'd say we should be able to add tests for all of
> locale in a week, and then take another week to clean up
> all the errors.

That's great. I could run the ITC tool on stdcxx sources afterwards  
and use those results as a starting point in adding the code to  
silence the errors -- assuming there're going to be any left in that  
part of the code.


View raw message