incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Liviu Nicoara <>
Subject Re: [RFC] commit-then-review vs review-then-commit
Date Wed, 16 May 2007 14:11:42 GMT
Martin Sebor wrote:
> Our recent status report raised a question from one of the reviewers
> about our commit policy, specifically about the following comment on
> it on our project page:
>   Except where noted, all stdcxx committers follow the Review Then
>   Commit policy.
> [...]
> So I would like to propose that we all follow a relaxed form of
> the Review-Then-Commit policy, where "simple" or "obviously safe"
> changes be allowed to go in under the Commit-Then-Review process.
> I don't think it's necessary to precisely define what "simple"
> or "obviously safe" means. It's a judgment call.
> Does this sound reasonable to everyone? Are we ready to have
> a vote on this proposal?

I think it sounds reasonable. I'm ready for a vote.


View raw message