Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <45F58FB4.2010008@roguewave.com>
Date: Mon, 12 Mar 2007 10:36:52 -0700
From: Martin Sebor <sebor@roguewave.com>
Organization: Rogue Wave Software
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
 rv:1.8.1.2) Gecko/20070221 SeaMonkey/1.1.1
MIME-Version: 1.0
To: stdcxx-dev@incubator.apache.org
Subject: Re: [Fwd: Re: svn commit: r511019 - in /incubator/stdcxx/trunk/tests:
 include/23.list.h src/23.containers.cpp]
References: <7BDB2168BEAEF14C98F1901FD2DE64384E205C@epmsa009.minsk.epam.com>
In-Reply-To: <7BDB2168BEAEF14C98F1901FD2DE64384E205C@epmsa009.minsk.epam.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Farid Zaripov wrote:
>> -----Original Message-----
>> From: Martin Sebor [mailto:sebor@roguewave.com] 
>> Sent: Monday, March 12, 2007 6:34 PM
>> To: stdcxx-dev@incubator.apache.org
>> Subject: [Fwd: Re: svn commit: r511019 - in 
>> /incubator/stdcxx/trunk/tests: include/23.list.h 
>> src/23.containers.cpp]
>>
>> Farid, please make sure to correct the static inline issue in 
>> this patch before we forget.
> 
>   Done:  http://svn.apache.org/viewvc?view=rev&rev=517283
> 
>>> +        const int equal =    size_ == state.size_
>> It probably doesn't matter (I don't think any compiler issues 
>> a warning) but I suppose the type of the constant should be int.
> 
>   Do you mean that here should be bool instead of int, right?

Yes, that's what I meant. Like I said, I'm not sure there's
a compiler that complains about bool to int conversions (MSVC
complains about going in the other direction which is annoying
as heck but I don't think it complains about this -- yet). The
main issue in this patch was the static inline since that as
we know causes real problems.

Martin