Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 1531 invoked from network); 8 Mar 2007 18:03:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Mar 2007 18:03:26 -0000 Received: (qmail 66074 invoked by uid 500); 8 Mar 2007 18:03:34 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 66064 invoked by uid 500); 8 Mar 2007 18:03:34 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 66051 invoked by uid 99); 8 Mar 2007 18:03:34 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Mar 2007 10:03:33 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Mar 2007 10:03:22 -0800 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l28I31eN025940 for ; Thu, 8 Mar 2007 18:03:01 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 8 Mar 2007 11:02:49 -0700 Message-ID: <45F0506D.6000406@roguewave.com> Date: Thu, 08 Mar 2007 11:05:33 -0700 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: typo in alloc.cpp References: <45EE25CC.7010209@roguewave.com> In-Reply-To: <45EE25CC.7010209@roguewave.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 08 Mar 2007 18:02:49.0744 (UTC) FILETIME=[FBEFB100:01C761AB] X-Virus-Checked: Checked by ClamAV on apache.org Martin Sebor wrote: > Mark Brown wrote: >> Hi, >> >> There appears to be a little typo in the source file alloc.cpp as >> pointed out by the gcc compilation error on Cygwin. The patch below >> fixes it. > > Thanks, this looks trivially correct to me. I'll let Farid > commit it since he'll be working on getting the 0.alloc.cpp > test to compile. Looks like he fixed both problems with this patch: http://svn.apache.org/viewvc?view=rev&rev=515619 Let us know if there still are problems. Martin > > Martin > >> >> gcc -c -I/home/mbrown/stdcxx/include/ansi -D_RWSTDDEBUG >> -D_RWSTD_USE_CONFIG -I/home/mbrown/stdcxx/include >> -I/home/mbrown/stdcxx-gcc-3.4.4-11s/include >> -I/home/mbrown/stdcxx/../rwtest -I/home/mbrown/stdcxx/tests/include >> -pedantic -nostdinc++ -g -W -Wall -Wcast-qual -Winline -Wshadow >> -Wwrite-strings -Wno-long-long -Wcast-align >> /home/mbrown/stdcxx/tests/src/alloc.cpp >> /home/mbrown/stdcxx/tests/src/alloc.cpp:97: error: comma at end of >> enumerator list >> /home/mbrown/stdcxx/tests/src/alloc.cpp: In function `DWORD >> _rw_translate_prot(int)': >> /home/mbrown/stdcxx/tests/src/alloc.cpp:120: warning: comparison >> between signed and unsigned integer expressions >> make[1]: *** [alloc.o] Error 1 >> make[1]: Leaving directory `/home/mbrown/stdcxx-gcc-3.4.4-11s/rwtest' >> make: *** [/home/mbrown/stdcxx-gcc-3.4.4-11s/rwtest/librwtest11s.a] >> Error 2 >> >> >> Index: /home/mbrown/stdcxx/tests/src/alloc.cpp >> =================================================================== >> --- /home/mbrown/stdcxx/tests/src/alloc.cpp (revision 514239) >> +++ /home/mbrown/stdcxx/tests/src/alloc.cpp (working copy) >> @@ -93,7 +93,7 @@ >> PROT_READ = 1 << 0, >> PROT_WRITE = 1 << 1, >> PROT_RDWR = PROT_READ | PROT_WRITE, >> - PROT_EXEC = 1 << 2, >> + PROT_EXEC = 1 << 2 >> }; >> >> #define MAP_PRIVATE 0 >> >> -- Mark >