Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 2307 invoked from network); 7 Mar 2007 20:28:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Mar 2007 20:28:00 -0000 Received: (qmail 25144 invoked by uid 500); 7 Mar 2007 20:28:08 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 25136 invoked by uid 500); 7 Mar 2007 20:28:08 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 25124 invoked by uid 99); 7 Mar 2007 20:28:08 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Mar 2007 12:28:08 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Mar 2007 12:27:57 -0800 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l27J9HTS022762 for ; Wed, 7 Mar 2007 19:22:51 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 7 Mar 2007 12:14:25 -0700 Message-ID: <45EF0FB4.1060103@roguewave.com> Date: Wed, 07 Mar 2007 12:17:08 -0700 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: [PATCH] Re: --compat mode behavior issues References: <45E4BA90.5090602@roguewave.com> <45EA0CAB.1070901@roguewave.com> <45ED9EF5.1060203@roguewave.com> <45EDA508.2040706@roguewave.com> <45EDAA15.8000601@roguewave.com> <45EDB071.4050501@roguewave.com> <45EDB740.6090502@roguewave.com> <45EDBD60.5050200@roguewave.com> <45EF082E.9020204@roguewave.com> In-Reply-To: <45EF082E.9020204@roguewave.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 07 Mar 2007 19:14:25.0702 (UTC) FILETIME=[D21D1C60:01C760EC] X-Virus-Checked: Checked by ClamAV on apache.org Andrew Black wrote: > Greetings Martin, all. > > Attached is a patch that partly rewrites the check_compat_test method, > taking the points raised below into consideration. > > Changelog: > * util/output.cpp (check_compat_test): Rewrite FSM to eliminate seek > to near end (was causing parsing issues on tests with output > following result block). Looks okay except for the bool keyword. If we're still hoping to someday compile the files with a C compiler we should avoid using C++ keywords or constructs. Martin