Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Message-ID: <14151983.1174079529258.JavaMail.jira@brutus>
Date: Fri, 16 Mar 2007 14:12:09 -0700 (PDT)
From: "Martin Sebor (JIRA)" <jira@apache.org>
To: stdcxx-dev@incubator.apache.org
Subject: [jira] Commented: (STDCXX-213) add header guard for #include
 <rw/_defs.h>
In-Reply-To: <1977406.1151517209833.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/STDCXX-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481762 ] 

Martin Sebor commented on STDCXX-213:
-------------------------------------

Partially implemented here: http://svn.apache.org/viewvc?view=rev&revision=374189
Not sure it's worth going beyond this.

> add header guard for #include <rw/_defs.h>
> ------------------------------------------
>
>                 Key: STDCXX-213
>                 URL: https://issues.apache.org/jira/browse/STDCXX-213
>             Project: C++ Standard Library
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 4.1.3, 4.1.2
>         Environment: all
>            Reporter: Martin Sebor
>         Assigned To: Martin Sebor
>            Priority: Minor
>
> Moved from the Rogue Wave bug tracking database:
> ****Created By: dean @ Jun 02, 2004 09:58:11 AM****
> Hi Kathy,
>   Here is the request that I have for additional work for RogueWave to do for us.  This is a minor request but has some big payback, especially when the RogueWave code is checked into ClearCase.  In my simple test, I reduced the number of include files that were opened from 200 to 100!  I haven't run the big test yet (the one that opens more than 2,400 header files.
>   The request is to add a different kind of header guard (in addition to the one that is currently being used).  For example, instead of the code:
> #include <rw/_defs.h>
> Use the code:
> #ifndef _RWSTD_DEFS_H_INCLUDED
>   #include <rw/_defs.h>
> #endif
>   This should be done in all header files and .cc files for all #includes that have header guards.
>   Let me know if this isn't clear or you have questions.
> Thanks,
> Bert
> **** Entered By: dean @ Wednesday, June 02, 2004 9:58:03 AM **** 
> ****Modified By: sebor @ Apr 11, 2005 03:11:29 PM****
> This is doable but it has been assumed that modern preprocessors implement this optimization. It would be useful to know what compiler the customer is using.
> Deferred for now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.