incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: typo in alloc.cpp
Date Thu, 08 Mar 2007 18:05:33 GMT
Martin Sebor wrote:
> Mark Brown wrote:
>> Hi,
>>
>> There appears to be a little typo in the source file alloc.cpp as 
>> pointed out by the gcc compilation error on Cygwin. The patch below 
>> fixes it.
> 
> Thanks, this looks trivially correct to me. I'll let Farid
> commit it since he'll be working on getting the 0.alloc.cpp
> test to compile.

Looks like he fixed both problems with this patch:

   http://svn.apache.org/viewvc?view=rev&rev=515619

Let us know if there still are problems.

Martin

> 
> Martin
> 
>>
>> gcc -c -I/home/mbrown/stdcxx/include/ansi -D_RWSTDDEBUG    
>> -D_RWSTD_USE_CONFIG -I/home/mbrown/stdcxx/include 
>> -I/home/mbrown/stdcxx-gcc-3.4.4-11s/include 
>> -I/home/mbrown/stdcxx/../rwtest -I/home/mbrown/stdcxx/tests/include  
>> -pedantic -nostdinc++ -g  -W -Wall -Wcast-qual -Winline -Wshadow 
>> -Wwrite-strings -Wno-long-long -Wcast-align   
>> /home/mbrown/stdcxx/tests/src/alloc.cpp
>> /home/mbrown/stdcxx/tests/src/alloc.cpp:97: error: comma at end of 
>> enumerator list
>> /home/mbrown/stdcxx/tests/src/alloc.cpp: In function `DWORD 
>> _rw_translate_prot(int)':
>> /home/mbrown/stdcxx/tests/src/alloc.cpp:120: warning: comparison 
>> between signed and unsigned integer expressions
>> make[1]: *** [alloc.o] Error 1
>> make[1]: Leaving directory `/home/mbrown/stdcxx-gcc-3.4.4-11s/rwtest'
>> make: *** [/home/mbrown/stdcxx-gcc-3.4.4-11s/rwtest/librwtest11s.a] 
>> Error 2
>>
>>
>> Index: /home/mbrown/stdcxx/tests/src/alloc.cpp
>> ===================================================================
>> --- /home/mbrown/stdcxx/tests/src/alloc.cpp     (revision 514239)
>> +++ /home/mbrown/stdcxx/tests/src/alloc.cpp     (working copy)
>> @@ -93,7 +93,7 @@
>>      PROT_READ  = 1 << 0,
>>      PROT_WRITE = 1 << 1,
>>      PROT_RDWR  = PROT_READ | PROT_WRITE,
>> -    PROT_EXEC  = 1 << 2,
>> +    PROT_EXEC  = 1 << 2
>>  };
>>  
>>  #define MAP_PRIVATE   0
>>
>> -- Mark
> 


Mime
View raw message