incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] Introducing struct ListIds
Date Wed, 21 Feb 2007 19:35:35 GMT
Farid Zaripov wrote:
>    ChangeLog:
>    * 23.list.h: New file with definitions of helpers used in
>    clause 23.list tests.
>    * 23.containers.cpp: #included 23.list.h; removed definition
>    of the temporary struct ListIds; _rw_list_sigcat filled by code.
> 
>  The patch and new file are attached.

This looks pretty good to me. I would just suggest to rename
ListStateT to ListState for consistency with StringState. It
would have been nice if ListState could have been an ordinary
class rather than a template but it would have made dealing
with iterators tricky.


Oh, another thing: please use the _TRY, _CATCH, and _RETHROW
macros to make the code portable to environments with no or
disabled exception support. Or, if you can avoid dealing
with exceptions (even at the risk of memory leaks), that
would be even better.

Martin

Mime
View raw message