Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 61840 invoked from network); 6 Dec 2006 23:56:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Dec 2006 23:56:44 -0000 Received: (qmail 71662 invoked by uid 500); 6 Dec 2006 23:56:53 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 71601 invoked by uid 500); 6 Dec 2006 23:56:53 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 71578 invoked by uid 99); 6 Dec 2006 23:56:52 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Dec 2006 15:56:52 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Dec 2006 15:56:42 -0800 Received: from qxvcexch01.ad.quovadx.com (qxvcexch01.ad.quovadx.com [192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id kB6NuHr8019081 for ; Wed, 6 Dec 2006 23:56:17 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 6 Dec 2006 16:56:46 -0700 Message-ID: <457758AD.2070209@roguewave.com> Date: Wed, 06 Dec 2006 16:56:29 -0700 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: missing assertion counts in exec output References: <457704E1.9050601@roguewave.com> <45773F17.7080307@roguewave.com> In-Reply-To: <45773F17.7080307@roguewave.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 06 Dec 2006 23:56:46.0630 (UTC) FILETIME=[301A5460:01C71992] X-Virus-Checked: Checked by ClamAV on apache.org Andrew Black wrote: > Greetings Martin. > > What is happening is that display.cpp blanks out the ASSERTS, FAILED, > and PERCNT columns if the total number of assertions is 0. A likely > cause for this condition is if no asserts occur. This is done for a > couple reasons. First, it hides these columns for the examples. Second, > it prevents divide by 0 errors. Attached is a patch that alters this > behavior. Okay. Please make sure to keep the Change Log line length below 80 characters. Also, as an FYI, unsigned int is the same thing as unsigned, so using the verbose form is unnecessary and redundant. I suggest you switch to the shorter form for brevity and consistency with int (we use plain int and long as opposed to "signed int" and "signed long int"). Thanks Martin