incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r465512 - /incubator/stdcxx/trunk/include/bitset.cc
Date Fri, 03 Nov 2006 00:15:51 GMT
faridz@apache.org wrote:
> Author: faridz
> Date: Wed Oct 18 23:53:06 2006
> New Revision: 465512
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=465512
> Log:
> 2006-10-19 Farid Zaripov <faridz@kyiv.vdiweb.com>
> 
> 	STDCXX-297
> 	* bitset.cc (__rw_bitset): Corrected calculation of
> 	size of the __bits buffer

I think the logic should be factored out into a function,
say __rw_bits_to_bytes, defined in bitset.cpp. That will
allow us to reduce the complexity of the code here (making
it smaller and faster to compile) while at the same time
letting us reuse the same logic in the char and wchar_t
overloads defined in bitset.cpp.

Martin

Mime
View raw message