Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 79574 invoked from network); 2 Oct 2006 21:11:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 2 Oct 2006 21:11:39 -0000 Received: (qmail 54810 invoked by uid 500); 2 Oct 2006 21:11:39 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 54747 invoked by uid 500); 2 Oct 2006 21:11:39 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 54736 invoked by uid 99); 2 Oct 2006 21:11:39 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Oct 2006 14:11:39 -0700 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received: from [208.30.140.160] ([208.30.140.160:54738] helo=moroha.quovadx.com) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id 28/58-24395-E7081254 for ; Mon, 02 Oct 2006 14:11:30 -0700 Received: from qxvcexch01.ad.quovadx.com (qxvcexch01.ad.quovadx.com [192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id k92LAZjL031339 for ; Mon, 2 Oct 2006 21:10:35 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 2 Oct 2006 15:11:01 -0600 Message-ID: <4521806B.4080100@roguewave.com> Date: Mon, 02 Oct 2006 15:11:07 -0600 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: [PATCH] stdlib patch References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 02 Oct 2006 21:11:01.0458 (UTC) FILETIME=[4377C320:01C6E667] X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Farid Zaripov wrote: [...] > This is a bug, but it's not present in 4.1.3 release. The bug was > introduced > here: http://svn.apache.org/viewvc?view=rev&revision=380995 I see. My bad. [...] > > The simple test: > > #include > #include > > int main (int, char**) > { > std::stringbuf buf; > buf.str ("123"); > assert (buf.str() == "123"); > buf.str ("456"); > assert (buf.str() == "456"); > return 0; > } > > The second assert fill fail in debug configurations because the buffer > filled by debug content > after __alloc.deallocate (). Okay. Since it's not a bug in a released version of the library we don't really need an issue for it. There does need to be a test to exercise it, though (the yet-to-be-written 27.stringbuf.cpp). So, please go ahead and commit your fix (thank you! :) separately from all the other changes and I'll get started on the test. I'll comment on the other issue(s) in a separate mail. Martin