From stdcxx-dev-return-2275-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Fri Oct 13 22:46:03 2006 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 39819 invoked from network); 13 Oct 2006 22:46:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 13 Oct 2006 22:46:03 -0000 Received: (qmail 31734 invoked by uid 500); 13 Oct 2006 22:46:02 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 31719 invoked by uid 500); 13 Oct 2006 22:46:02 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 31708 invoked by uid 99); 13 Oct 2006 22:46:02 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Oct 2006 15:46:02 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Oct 2006 15:46:01 -0700 Received: from qxvcexch01.ad.quovadx.com (qxvcexch01.ad.quovadx.com [192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id k9DMj6bc011593 for ; Fri, 13 Oct 2006 22:45:07 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 13 Oct 2006 16:45:53 -0600 Message-ID: <4530172B.9020801@roguewave.com> Date: Fri, 13 Oct 2006 16:46:03 -0600 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: svn commit: r463535 - in /incubator/stdcxx/trunk: etc/config/makefile.common etc/config/makefile.rules util/cmdopt.cpp util/display.cpp util/output.cpp util/runall.cpp util/target.h References: <20061013004936.5235E1A981A@eris.apache.org> <45300BE8.6010403@roguewave.com> In-Reply-To: <45300BE8.6010403@roguewave.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 13 Oct 2006 22:45:53.0666 (UTC) FILETIME=[56D50620:01C6EF19] X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Martin Sebor wrote: > sebor@apache.org wrote: > >> Author: sebor >> Date: Thu Oct 12 17:49:34 2006 >> New Revision: 463535 >> >> URL: http://svn.apache.org/viewvc?view=rev&rev=463535 >> Log: >> 2006-10-12 Andrew Black >> >> * makefile.rules (%.o: %(AS_EXT), %.o: %.cpp, %: %.o, %: %.cpp): Add >> $(TEEOPTS) to compile/link line so that output is routed to log >> files. > > > Andrew, I'm afraid there's a problem with this patch. The exit status > of a pipeline is the exit status of the last command so piping stderr > of the compiler (or linker) to tee will cause the pipeline to exit with > the status of tee rather than that of the compiler or linker. That in > turn prevents make from stopping after a compiler or linker error and > allows it to continue processing subsequent commands. I'm going to have > to revert the makefile changes. Can you please look into how else this > could be done? FYI, we might be able to use the PIPESTATUS bash special variable when the shell is bash. With shells that don't provide equivalent functionality we will either need to come up with an alternative (e.g., our own implementation of a pipe that returns the exit status of the first command instead of the last one), or count the warnings only in batch builds and skip that part in interactive ones. Are there any other options? Martin