incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Black <abl...@roguewave.com>
Subject Re: [PATCH] wall clock timing
Date Mon, 16 Oct 2006 15:34:01 GMT
Martin Sebor wrote:
> Andrew Black wrote:
[...]
>>
>> Log:
> [...]
>>     * display.h (unistd.h) [!_WIN32 && !_WIN64]: Remove dependency.
>>       (print_status_plain): Alter logic used to print times, 
>> reflecting change to target_status.
> 
> I don't see these changes in the patch. What's up?
> 
> Martin
> 

The problem is a typo in the change log.  The file being altered is 
display.cpp, not display.h.  I also spotted another couple mistakes in 
the change log, so a corrected version follows, and I've attached a 
slightly updated patch that resolves the conflicts introduced in r463535.

Log:
     * cmdopt.h (TICKS_PER_SEC): Declare global constant
     * cmdopt.cpp (TICKS_PER_SEC): Define, value dependent on 
pre-processor declarations.
     * target.h (sys/types.h): Include for clock_t.
       (sys/time.h) [!_WIN32 && !_WIN64 && _XOPEN_UNIX]: Remove dependency.
       (rw_timeval): Remove as unneeded.
       (rw_time_t, rw_suseconds_t) [!_XOPEN_UNIX]: Ditto.
       (target_status): Use clock_t rather than rw_timeval.
     * exec.cpp (sys/times.h) [!_WIN32 && !_WIN64]: Include.
       (sys/time.h) [!_WIN32 && !_WIN64 && _XOPEN_UNIX]: Remove dependency.
       (calculate_usage) [!_WIN32 && !_WIN64]: Update documentation, 
alter signature, use times() rather than getrusage() to retrieve timing 
information.
       (exec_file) [!_WIN32 && !_WIN64]: Move wall clock timing logic 
into calculate_usage, retrieve starting times prior to wait_for_child()
       exec_file) [_WIN32 || _WIN64]: Simplify wall clock delta logic.
     * display.cpp (unistd.h) [!_WIN32 && !_WIN64]: Remove dependency.
       (print_status_plain): Alter logic used to print times, reflecting 
change to target_status.

--Andrew Black

Mime
View raw message