incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] Scripts, generating solution and projects for MSVC/ICC [2]
Date Fri, 29 Sep 2006 22:43:05 GMT
Farid Zaripov wrote:
>   Patch for scripts of Windows build infrastructure is here:
> http://people.apache.org/~faridz/windows.diff

Please go ahead and commit this. Andrew and I will test it on our
end and let you know if there are any issues.

Btw., I noticed that the _RWBUILD_std macro is (still) being
#defined. It shouldn't be. Can you please take it out? (Since
this isn't something new introduced in your patch feel free
to do it later, after committing your initial changes.)

Also, it would be good to document the variables defined in the
.config files. I have an idea what CPPFLAGS might be but what's
CONVERT or SLNVER (these are rhetorical questions)? While on the
subject of these variables, shouldn't -qnoipo be defined in LDFLAGS
rather than in LD? And shouldn't we be using cl (or icl) to link
instead of invoking the linker directly? Finally, it seems that we
should try to define variables according to the same principle as
in the UNIX .config files, i.e., <variable>.<suffix>, such as the
recently introduced CXXFLAGS.wide, LDFLAGS.wide, LDSOFLAGS.wide,
and ARFLAGS.wide variable and their narrow counterparts (I'd like
to change the rest of the UNIX variables to follow the same
convention, e.g., rename MULTI_XYZFLAGS to XYZFLAGS.thread, or
STATIC_XYZFLAGS to XYZFLAGS.static, etc.) This is obviously an
enhancement so it shouldn't hold up your patch.

Thanks
Martin

Mime
View raw message