incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] exec utility display subsystem
Date Thu, 07 Sep 2006 02:37:18 GMT
Andrew Black wrote:
> Greetings all.
> 
> Take 2 on this patch.  I believe the same change log can be used, 
> despite the number of implementation changes.

Thanks. Committed thus:
   http://svn.apache.org/viewvc?view=rev&rev=440934

I suppose we can rename the files in a subsequent commit.

[...]
> Index: util/output.cpp
> ===================================================================
> --- util/output.cpp	(revision 437752)
> +++ util/output.cpp	(working copy)
[...]
> @@ -110,10 +100,10 @@
>                     expected to be active, so invert the total */
>                  if (8 == r_lvl && 0 == strcmp (target_name, "0.new"))
>                      r_active = r_total-r_active;
> -                failed += r_active;
> -                asserts += r_total;
> -                if (failed < r_active || asserts < r_total) {
> -                    puts (" OFLOW");
> +                status->failed += r_active;
> +                status->assert += r_total;

I would have almost expected the assert above to get expanded by
the preprocessor. The only reason it doesn't is because there are
no parentheses after it and assert is a functional macro. Still,
we should probably rename status->assert to status->asserts in
case there is a preprocessor that trips up on this.

Martin

Mime
View raw message