incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Black <>
Subject Re: [PATCH]
Date Wed, 30 Aug 2006 18:14:41 GMT

Attached are a pair of quick patches that revisit these regular 
expressions.  Change log for each patch is below.  I suppose they could 
be committed together if desired.

--Andrew Black

ansi_fix.diff change log:
	* (test_locale()): Correct locale target name 
conversion patterns to handle the ANSI_X3.4-1968 character map correctly.

pattern_sync.diff change log:
	* GNUmakefile.bin ($(LOCALE_LIST), $(DEPENDDIR)/localedb.d): Simplify 
and standardize sed patterns used to convert locale target names into 
locale and character map parameters.

Martin Sebor wrote:
> Andrew Black wrote:
>> Greetings Farid
>> May I propose the patch below as an alternative solution?  While the 
>> cost of running tr in addition to sed isn't too great in the grand 
>> scheme of things, this removes the additional overhead of the second 
>> function call.
> I applied your patch until the names have been changed:
>> It might be worthwhile to also look at the regular expressions used in 
>> GNUmakefile.bin file, particularly the rules for $(LOCALE_LIST) and 
>> $(DEPENDDIR)/localedb.d.  Each of these locations has logic that makes 
>> similar translations.
> Would you like to put together a patch? If not, could you please
> open an issue so we don't forget? (A test case or something along
> those lines demonstrating the problem you are pointing out would
> be most helpful.)
>> A related issue I'm observing is that the en_US.ANSI_X3.4-1968 locale 
>> fails as follows.
> Same here (issue + patch please :)
> Thanks
> Martin
>>  ./ -d
>> RWSTD_SRC_ROOT=/build/ablack/stdcxx-test/etc/nls
>> export RWSTD_SRC_ROOT
>> RWSTD_LOCALE_ROOT=/tmp/locale.13281
>> ./localedef -w -c -f 
>> /build/ablack/stdcxx-test/etc/nls/charmaps/ANSI_X3 -i 
>> /build/ablack/stdcxx-test/etc/nls/src/en_US.4-1968 
>> /tmp/locale.13281/en_US.ANSI_X3.4-1968 2>/dev/tty
>> Error 500: /build/ablack/stdcxx-test/etc/nls/charmaps/ANSI_X3 could 
>> not be opened for reading

View raw message