From stdcxx-dev-return-1728-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Tue Jul 11 16:38:21 2006 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 36959 invoked from network); 11 Jul 2006 16:38:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 11 Jul 2006 16:38:21 -0000 Received: (qmail 64362 invoked by uid 500); 11 Jul 2006 16:38:21 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 64358 invoked by uid 500); 11 Jul 2006 16:38:20 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 64347 invoked by uid 99); 11 Jul 2006 16:38:20 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jul 2006 09:38:20 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jul 2006 09:38:20 -0700 Received: from qxvcexch01.ad.quovadx.com (qxvcexch01.ad.quovadx.com [192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.4) with ESMTP id k6BGbgXg016287 for ; Tue, 11 Jul 2006 16:37:42 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 11 Jul 2006 10:38:01 -0600 Message-ID: <44B3D3FE.7020600@roguewave.com> Date: Tue, 11 Jul 2006 10:38:22 -0600 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: test for lib.string.io References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 11 Jul 2006 16:38:01.0049 (UTC) FILETIME=[5FB27490:01C6A508] X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Farid Zaripov wrote: > I see that 07/09 rw_ctype.h and ctype.cpp files were added to the svn. > > Should the test 21.string.io use the UserCtype facet instead of > the Ctype facet defined in 21.string.io.cpp? That's the idea, yes :) Although we should probably finish the test. The test I committed is incomplete -- all it exercises is UserCtype::is(). > > Currently UserCtype is not inherited from > std::ctype and stream class cannot use this facet. That would be a problem, wouldn't it ;-) The library is required to provide only ctype and ctype and the primary template need not exist. Let me add the UserChar specialization. > > And I found that UserCtype::id is declared but not defined > (should be defined in ctype.cpp). Let me fix this as well. Thanks for pointing it out! Martin