incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Black <abl...@roguewave.com>
Subject Re: runall.sh replacement
Date Tue, 25 Jul 2006 17:05:34 GMT
Greetings Martin

Attached is a patch that tries to address the formatting issues 
remaining.  I'm still not certain I've caught everything, but it's a 
starting point.

--Andrew Black

Log:
2006-07-25  Andrew Black <ablack@roguewave.com>
	* cmdopt.cpp: Formatting cleanup.
	* exec.cpp: Same.
	* output.cpp: Same.
	* runall.cpp: Same.
	* util.cpp: Same.

Martin Sebor wrote:
> Andrew Black wrote:
>> Revised patch attached.
>>
>> One change that I made while working on the self-test logic was to 
>> split the output parsing logic into parse_output.cpp/h.  I suspect 
>> you'll have a better name for the file.  That was bundled into this 
>> patch as I didn't take the time to back those changes out.
> 
> Okay, I made a number of changes and committed everything here:
> http://svn.apache.org/viewvc?rev=425242&view=rev
> 
> One important change was removing the non-portable "-q" option
> from the invocation of diff (it was causing problems on Solaris).
> 
> I would still like to see a patch addressing the formatting issues
> I pointed out initially (http://tinyurl.com/mmqgv), preferably
> before any other changes to the utility.
> 
> Thanks!
> Martin

Mime
View raw message