incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Farid Zaripov <Far...@kyiv.vdiweb.com>
Subject RE: design of testuite exceptions (was: Re: svn commit: r418319 - /incubator/stdcxx/trunk/tests/strings/21.string.io.cpp)
Date Wed, 12 Jul 2006 16:18:13 GMT
    Martin, I implemented your latest notes about testsuite exception 
(rw_exception.h, exception.cpp). The updated version is attached.


 > -----Original Message-----
 > From: Martin Sebor [mailto:sebor@roguewave.com]
 > Sent: Wednesday, July 12, 2006 4:27 AM
 > To: stdcxx-dev@incubator.apache.org
 > Subject: Re: design of testuite exceptions (was: Re: svn
 > commit: r418319 -
 > /incubator/stdcxx/trunk/tests/strings/21.string.io.cpp)
 >
 > Okay. I think I would still like to remove the logtostderr
 > argument and do the logging in new.cpp.
   Done

 > Also, it would be more efficient to avoid catching and
 > rethrowing the exception only to call va_end() on the
 > argument list.
   Done

 > Finally,
[...]
 > we want to catch the same type and
 > maybe just throw different (but not visible) types derived
 > from it.
   Done

 > Moving on to allocator.cpp
[...]
 > the fifth argument to rw_throw: "SharedAlloc::funcall"
 > should be the name of the function or 0 (in which case
 > rw_throw would need to avoid trying to format it):
   Done

 > I would be happier with catching the exception here (by
 > reference), logging the what() string when logging/tracing is
 > enabled, and then rethrowing it, than be stuck with the extra
 > argument to rw_throw().
   Done


Farid.

Mime
View raw message