Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 7200 invoked from network); 14 Jun 2006 19:53:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Jun 2006 19:53:13 -0000 Received: (qmail 30543 invoked by uid 500); 14 Jun 2006 19:53:13 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 30490 invoked by uid 500); 14 Jun 2006 19:53:12 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 30473 invoked by uid 99); 14 Jun 2006 19:53:12 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Jun 2006 12:53:12 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Jun 2006 12:53:11 -0700 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.4/8.13.4) with ESMTP id k5EJqCg7030069 for ; Wed, 14 Jun 2006 19:52:14 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 14 Jun 2006 13:53:04 -0600 Message-ID: <44906914.909@roguewave.com> Date: Wed, 14 Jun 2006 13:52:52 -0600 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: svn commit: r412249 - in /incubator/stdcxx/trunk/tests: include/21.strings.h src/21.strings.cpp References: <4D6A8407B7AC6F4D95B0E55C4E7C4C620465152D@exmsk.moscow.vdiweb.com> In-Reply-To: <4D6A8407B7AC6F4D95B0E55C4E7C4C620465152D@exmsk.moscow.vdiweb.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 Jun 2006 19:53:05.0000 (UTC) FILETIME=[26A46680:01C68FEC] X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Anton Pevtsov wrote: > Martin Sebor wrote: > >>This seems to include the changes for reverse_iterator. Shouldn't > > those be implemented separately (and in the driver instead)? > > Yes. I committed changes for range overloads in cons test here: > http://svn.apache.org/viewvc?rev=414235&view=rev > > > The updated test and test driver which supports the reverse iterators > are here: > http://people.apache.org/~antonp/stdcxx06142006/ This looks great, thanks! Could you please just give the reverse_results helper function internal linkage (i.e., declare is static) and rename it to _rw_reverse_results according to the naming convention? With that go ahead and commit. Martin