Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 73257 invoked from network); 29 May 2006 15:30:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 29 May 2006 15:30:06 -0000 Received: (qmail 8916 invoked by uid 500); 29 May 2006 15:30:06 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 8868 invoked by uid 500); 29 May 2006 15:30:05 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 8856 invoked by uid 99); 29 May 2006 15:30:05 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 May 2006 08:30:05 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of AntonP@moscow.vdiweb.com designates 195.210.189.132 as permitted sender) Received: from [195.210.189.132] (HELO mail.moscow.vdiweb.com) (195.210.189.132) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 May 2006 08:30:04 -0700 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: factoring out more test code Date: Mon, 29 May 2006 19:29:40 +0400 Message-ID: <4D6A8407B7AC6F4D95B0E55C4E7C4C62044B413E@exmsk.moscow.vdiweb.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: factoring out more test code Thread-Index: AcaCs9cHXXA36WVVQZS2PsYcVycBgAAgM8lw From: "Anton Pevtsov" To: X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Martin, unfortunately, these changes results in segmentation fault both on Windows and Unix. I'll investigate this, but could you take a look on it too when you have a chance? Thanks, Anton Pevtsov -----Original Message----- From: Martin Sebor [mailto:sebor@roguewave.com]=20 Sent: Monday, May 29, 2006 04:07 To: stdcxx-dev@incubator.apache.org Subject: Re: factoring out more test code Martin Sebor wrote: > Anton Pevtsov wrote: >=20 >> Looks good. I thnik this helps us to reduce the identical code in=20 >> tests, escpecially when "range" cases are exercised. Also it is=20 >> possible to update the tests one by one, isn't it? >=20 >=20 > Yes, I believe so. Let me start working on changing the rest of the=20 > tests. I've added the template to 21.strings.h and changed the replace test. I also made some other changes (the function pointer array) but I want to see a full set of test results before we adopt them in other tests as well in case they run into compiler issues (such as gcc bug 27788: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D27788 that I had to work around). The changes are here: http://svn.apache.org/viewvc?rev=3D410005&view=3Drev http://svn.apache.org/viewvc?rev=3D410006&view=3Drev Martin PS Tomorrow's Memorial Day so I'll respond Tuesday to any comments you might have.